re-add mkdirs call before starting localstack docker container#7944
Merged
re-add mkdirs call before starting localstack docker container#7944
Conversation
alexrashed
approved these changes
Mar 23, 2023
Member
alexrashed
left a comment
There was a problem hiding this comment.
LGTM! This is just a symptom of the CLI being intertwined with the runtime. We'll fix this particular issue along the way, and in the long run we should really try to get the CLI in a completely separate package. 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like something is still not quite right with the directories and the way they are initialized depending on the environment.
The log files from the CLI tests in master suggest that some directories are again not created properly.
It's not clear to me why the file is
/var/lib/localstack/tmp/localstack_main_container.log- it should not be/var/lib/localstackwhen starting the cli. need to investigate further and clean this up, but adding this band-aid for now.log output from the test (very easy to read 😬 )