Skip to content

add fix for CLI tests to properly set CLI context #7939

Merged
thrau merged 3 commits intov2from
v2-fix-cli-tests
Mar 23, 2023
Merged

add fix for CLI tests to properly set CLI context #7939
thrau merged 3 commits intov2from
v2-fix-cli-tests

Conversation

@thrau
Copy link
Member

@thrau thrau commented Mar 23, 2023

without setting LOCALSTACK_CLI=1, the config.dirs are not set to the CLI directories, but the the host-mode directories using .filesystem.

localstack/localstack/config.py

Lines 1096 to 1103 in a12e673

def init_directories() -> Directories:
if is_in_docker:
return Directories.for_container()
else:
if is_env_true("LOCALSTACK_CLI"):
return Directories.for_cli()
return Directories.for_host()

we are setting LOCALSTACK_CLI=1 here, but this is never called in the tests:

localstack/localstack/cli/main.py

Lines 4 to 6 in a12e673

def main():
# indicate to the environment we are starting from the CLI
os.environ["LOCALSTACK_CLI"] = "1"

@thrau thrau requested a review from alexrashed March 23, 2023 13:49
@thrau thrau temporarily deployed to localstack-ext-tests March 23, 2023 13:49 — with GitHub Actions Inactive
alexrashed
alexrashed approved these changes Mar 23, 2023
View reviewed changes
Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@thrau thrau temporarily deployed to localstack-ext-tests March 23, 2023 13:57 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Mar 23, 2023

LocalStack integration with Pro

1 827 tests   - 1   1 480 ✔️  - 1   1h 3m 50s ⏱️ - 2m 25s
       1 suites ±0      346 💤 ±0 
       1 files   ±0          1 ❌ ±0 

For more details on these failures, see this check.

Results for commit 941c454. ± Comparison against base commit a12e673.

@thrau thrau temporarily deployed to localstack-ext-tests March 23, 2023 15:31 — with GitHub Actions Inactive
@thrau thrau merged commit 0f750ae into v2 Mar 23, 2023
@thrau thrau deleted the v2-fix-cli-tests branch March 23, 2023 15:50
alexrashed pushed a commit that referenced this pull request Mar 23, 2023
@thrau @alexrashed
add fix for CLI tests to properly set CLI context (#7939)
ee34ca6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexrashed alexrashed alexrashed approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thrau @alexrashed