7910 support having a grant with the same name on different keys#7911
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
localstack-bot
left a comment
There was a problem hiding this comment.
Welcome to LocalStack! Thanks for raising your first Pull Request and landing in your contributions. Our team will reach out with any reviews or feedbacks that we have shortly. We recommend joining our Slack Community and share your PR on the #community channel to share your contributions with us. Please make sure you are following our contributing guidelines and our Code of Conduct.
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
|
It looks like the failing test is related to DynamoDB rest tests, which shouldn't be impacted by this change at all. Is it possible to have that test re-run? |
viren-nadkarni
left a comment
There was a problem hiding this comment.
LGTM!
Thanks for contributing @BlueDragon23!
This change addresses this issue #7910
Previously, due to the
grant_namesonly mapping from grant name to grant ID, it was impossible to have more than one grant with the same name across keys. By including the key ID in the mapping, it becomes possible.I've added a unit test to demonstrate the fix works, and allows this grant to be created on both keys.
If any extra test coverage would help, just point me in the right direction!