Add support for VPC endpoints for private API Gateway REST APIs#7905
Merged
Add support for VPC endpoints for private API Gateway REST APIs#7905
Conversation
whummer
commented
Mar 18, 2023
7a5d49d to
45465d7
Compare
45465d7 to
0c4c85e
Compare
dfangl
reviewed
Mar 19, 2023
bentsku
approved these changes
Mar 21, 2023
Contributor
bentsku
left a comment
There was a problem hiding this comment.
LGTM! 🎉 Thanks a lot for tackling this! It's so great to see how we can add functionality using 2 different services and it being so clear with ASF now. And so nice to see it AWS validated, and making it easier to fix the parity. Only one minor nit in the ec2 provider, but nothing blocking for me. 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for VPC endpoints for private API Gateway REST APIs. See docs here.
These endpoints allow users to invoke REST APIs under the following endpoints:
... in addition to the standard API GW invocation endpoints:
A snapshot test has been added to cover the functionality.
More detailed description following soon..