Conversation
thrau
approved these changes
Mar 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently in the process of trying to create some sample concerning CORS configuration of S3, and making a small sample allowing people to create their own CORS rules for their bucket but still allowing the
app.localstack.cloud/ resource browser to access it, I've encountered an issue with theListBucketsoperation.S3 is a "self-managed" CORS service, as it can manage the CORS setting of its buckets. However, the
ListBucketsoperation is not configurable, and should be using the default CORS setting of LocalStack. I've added a check in our general CORS handler to not skip setting CORS headers if the operation isListBuckets.While creating the test, I've also found that if you try to access
http://localhost:4566, it should returnListBuckets, but our service name parser does not recognise the request as it's not signed.Funnily, in AWS, if you do the same and try to access
s3.amazonaws.comwhich is the default URL forListBucketsinus-east-1without signing the request, you get redirected to https://aws.amazon.com/s3/.If you use
s3.localhost.localstack.cloudwithout signing the request, you'll get the response forListBucketsbecause of the host matching.Should we match on the path being
/as a sign of an S3 request?