Conversation
These variables are * `LOCALSTACK_HOSTNAME` which is not _meant_ to be settable by the user as it's used internally, but it is settable * `LOCALSTACK_HOST` which is a new variable that we plan to use in exchange for `HOSTNAME_EXTERNAL` and `LOCALSTACK_HOSTNAME`. These variables are added so that we can use the analytics to see the usage of the previous variables drop.
ackdav
approved these changes
Mar 16, 2023
Member
ackdav
left a comment
There was a problem hiding this comment.
LGTM 👍 thanks for adding this before v2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These variables are
LOCALSTACK_HOSTNAMEwhich is not meant to be settable by the user as it's used internally, but it is settableLOCALSTACK_HOSTwhich is a new variable that we plan to use in exchange forHOSTNAME_EXTERNALandLOCALSTACK_HOSTNAME.These variables are added so that we can use the analytics to see the usage of the previous variables drop.