Return RSA public key in SPKI format#7856
Merged
viren-nadkarni merged 1 commit intolocalstack:masterfrom Mar 15, 2023
Merged
Conversation
Contributor
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Contributor
localstack-bot
left a comment
There was a problem hiding this comment.
Welcome to LocalStack! Thanks for raising your first Pull Request and landing in your contributions. Our team will reach out with any reviews or feedbacks that we have shortly. We recommend joining our Slack Community and share your PR on the #community channel to share your contributions with us. Please make sure you are following our contributing guidelines and our Code of Conduct.
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
localstack-bot
added a commit
that referenced
this pull request
Mar 13, 2023
ce4676f to
60c1f7a
Compare
Fixes localstack#7216 Return the public key in SubjectPublicKeyInfo format for both RSA and ECDSA keys, per the AWS documentation: https://docs.aws.amazon.com/cli/latest/reference/kms/get-public-key.html#output
60c1f7a to
15e76ca
Compare
viren-nadkarni
approved these changes
Mar 15, 2023
Member
viren-nadkarni
left a comment
There was a problem hiding this comment.
Checked that other KMS operations using pubkey are unaffected.
LGTM! Thanks for contributing @laszlovandenhoek!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7216
Return the public key in SubjectPublicKeyInfo format for both RSA and ECDSA keys, per the AWS documentation: https://docs.aws.amazon.com/cli/latest/reference/kms/get-public-key.html#output
Please refer to the contribution guidelines in the README when submitting PRs.