Skip to content

Fix multiple AWS::Lambda::Permission for single function#7832

Merged
dominikschubert merged 2 commits intomasterfrom
fix_cfn-lambda-permission
Mar 10, 2023
Merged

Fix multiple AWS::Lambda::Permission for single function#7832
dominikschubert merged 2 commits intomasterfrom
fix_cfn-lambda-permission

Conversation

@dominikschubert
Copy link
Member

A single lambda function can be associated with multiple AWS::Lambda::Permission resources. This was fundamentally incompatible with how the previous fetch_state "worked'.

Changes

  • Added a test for adding multiple AWS::Lambda::Permission resources for a single function
  • Fixed fetch_state & physical resource id for AWS::Lambda::Permission
  • Fixed overwriting Code properties in AWS::Lambda::Function which lead to unnecessary updates in certain cases

@dominikschubert dominikschubert requested a review from pinzon March 9, 2023 20:16
@dominikschubert dominikschubert requested a review from dfangl as a code owner March 9, 2023 20:16
@dominikschubert dominikschubert self-assigned this Mar 9, 2023
@dominikschubert dominikschubert temporarily deployed to localstack-ext-tests March 9, 2023 20:17 — with GitHub Actions Inactive
@dominikschubert dominikschubert temporarily deployed to localstack-ext-tests March 9, 2023 21:17 — with GitHub Actions Inactive
@coveralls
Copy link

Coverage Status

Coverage: 85.094% (-0.04%) from 85.134% when pulling 099a2d8 on fix_cfn-lambda-permission into e7836bf on master.

@github-actions
Copy link

github-actions bot commented Mar 9, 2023

LocalStack integration with Pro

       3 files  ±0         3 suites  ±0   1h 30m 14s ⏱️ - 13m 23s
1 788 tests +1  1 406 ✔️ +2  382 💤  - 1  0 ±0 
2 514 runs  +1  1 780 ✔️ +2  734 💤  - 1  0 ±0 

Results for commit 099a2d8. ± Comparison against base commit e7836bf.

Copy link
Member

@pinzon pinzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dominikschubert dominikschubert merged commit 4914f48 into master Mar 10, 2023
@dominikschubert dominikschubert deleted the fix_cfn-lambda-permission branch March 10, 2023 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants