Skip to content

Fix error with threads not having _target attributes#7829

Merged
dfangl merged 1 commit intomasterfrom
fix-thread-leakage
Mar 9, 2023
Merged

Fix error with threads not having _target attributes#7829
dfangl merged 1 commit intomasterfrom
fix-thread-leakage

Conversation

@dfangl
Copy link
Member

@dfangl dfangl commented Mar 9, 2023

Motivation

Master build is currently red due to some threads not having the _target attribute, and the thread leakage detection therefore failing.

Changes

Check if a thread has the _target attribute before accessing it, otherwise just print None.

@dfangl dfangl requested a review from dominikschubert as a code owner March 9, 2023 18:11
@dfangl dfangl temporarily deployed to localstack-ext-tests March 9, 2023 18:11 — with GitHub Actions Inactive
Copy link
Member

@dominikschubert dominikschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dfangl dfangl merged commit e7836bf into master Mar 9, 2023
@dfangl dfangl deleted the fix-thread-leakage branch March 9, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants