Skip to content

Add DELETE to the _localstack/ses/ endpoint#7816

Merged
viren-nadkarni merged 5 commits intolocalstack:masterfrom
justinwyer:feature/http-delete-on-ses
Mar 9, 2023
Merged

Add DELETE to the _localstack/ses/ endpoint#7816
viren-nadkarni merged 5 commits intolocalstack:masterfrom
justinwyer:feature/http-delete-on-ses

Conversation

@justinwyer
Copy link
Contributor

@justinwyer justinwyer commented Mar 7, 2023 •
edited
Loading

Resolves #7491

Added the following endpoints:

  • DELETE _localstack/ses requested by the issue
  • DELETE _localstack/ses?id=<message_id> requested in a comment
  • GET _localstack/ses?id=<message_id> added to match the DELETE by id

localstack-bot
localstack-bot reviewed Mar 7, 2023
View reviewed changes
Copy link
Contributor

@localstack-bot localstack-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to LocalStack! Thanks for raising your first Pull Request and landing in your contributions. Our team will reach out with any reviews or feedbacks that we have shortly. We recommend joining our Slack Community and share your PR on the #community channel to share your contributions with us. Please make sure you are following our contributing guidelines and our Code of Conduct.

@localstack-bot
Copy link
Contributor

localstack-bot commented Mar 7, 2023 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@justinwyer
Copy link
Contributor Author

justinwyer commented Mar 7, 2023

I have read the CLA Document and I hereby sign the CLA

localstack-bot added a commit that referenced this pull request Mar 7, 2023
@localstack-bot
@justinwyer has signed the CLA from Pull Request #7816
67e2f92
@justinwyer
Copy link
Contributor Author

justinwyer commented Mar 7, 2023

As part of the testing I was using the _aws/ses endpoint but had to switch to _localstack/ses as the message_id parameter in the route _localstack/ses/<message_id> parameter was not working with the _aws prefix. If you can shed some light as to why this might be I would be happy to fix that.

@justinwyer
Copy link
Contributor Author

justinwyer commented Mar 7, 2023

I am not sure what Circle CI is upset about exactly, perhaps someone can rerun the workflow?

viren-nadkarni
viren-nadkarni requested changes Mar 8, 2023
View reviewed changes
viren-nadkarni
viren-nadkarni requested changes Mar 9, 2023
View reviewed changes
Copy link
Member

@viren-nadkarni viren-nadkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my comments. Just a few minor points and we can merge this 👍

justinwyer and others added 3 commits March 9, 2023 10:37
@justinwyer @viren-nadkarni
Update tests/integration/test_ses.py
45852d2 
Co-authored-by: Viren Nadkarni <viren.nadkarni@gmail.com>
@justinwyer @viren-nadkarni
Update tests/integration/test_ses.py
dbf3e48 
Co-authored-by: Viren Nadkarni <viren.nadkarni@gmail.com>
@justinwyer @viren-nadkarni
Update tests/integration/test_ses.py
9cd8066 
Co-authored-by: Viren Nadkarni <viren.nadkarni@gmail.com>
@viren-nadkarni viren-nadkarni mentioned this pull request Mar 9, 2023
Merged
@viren-nadkarni viren-nadkarni merged commit 1d93107 into localstack:master Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@localstack-bot localstack-bot localstack-bot left review comments

@viren-nadkarni viren-nadkarni viren-nadkarni approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feature request: implement DELETE /_localstack/ses endpoint

3 participants

@justinwyer @localstack-bot @viren-nadkarni