Conversation
|
Failing tests are unrelated since this doesn't actually affect the code 🙂 |
steffyP
left a comment
There was a problem hiding this comment.
Nice work 🚀
Finally, we can stop guessing how old the most snapshot tests really are 😄 This will be very helpful for automating the snapshot updates in the future 🤩
Just one thing I discovered: we have some snapshot-tests "hidden" in subfolders, it would be great if we could also iterate sub directories and search for additional snapshot-files 🙂
scripts/gather_outdated_snapshots.py
Outdated
| Fetches all snapshots in PATH that were recorded before the given DATE_LIMIT. | ||
| Format of the DATE_LIMIT-string must be "DD-MM-YYYY". | ||
|
|
||
| Example usage: python get_snapshots.py ../tests/integration 24-12-2022 |
There was a problem hiding this comment.
NIT: I think you renamed the file to gather_outdated_snapshots.py, would be nice to change the example usage here :)
scripts/gather_outdated_snapshots.py
Outdated
| outdated_snapshots = [] | ||
| if not path.endswith("/"): | ||
| path = f"{path}/" | ||
| for file in os.listdir(path): |
There was a problem hiding this comment.
we might need to check sub-folders as well, e.g. for s3 there are some snapshot files in a sub-directory
|
Changes Unknown when pulling 49c29b4 on gather-outdated-snapshots into ** on master**. |
This adds a scripts that enables to gather which snapshots are older than a given date. The data is gathered within a JSON object
The data includes at the moment: