Merged
Conversation
df020b5 to
ebef037
Compare
ebef037 to
970a3d9
Compare
thrau
reviewed
Feb 22, 2023
Member
thrau
left a comment
There was a problem hiding this comment.
Looks mostly good to me! Just a couple of comments.
I wonder what we'll do about the CLI tests to get the coverage information?
Member
Author
@dfangl also raised concerns about the CLI tests (since we need to identify incompatibilities with Python < 3.10 asap). |
f2e9e25 to
ab4a103
Compare
thrau
approved these changes
Feb 24, 2023
Member
thrau
left a comment
There was a problem hiding this comment.
This looks pretty good now! Let's release and merge? ;)
ab4a103 to
dad4b3c
Compare
dad4b3c to
bd37086
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a preparation for upcoming changes with v2 concerning the packaging and Docker image structure.
With this PR, the python distribution which is published from this repository is renamed from
localstacktolocalstack-core.It loses its dependency on our "extensions" distribution (which will resolve the build and release issues due to our cyclic dependency, and will introduce a clear separation between community and pro).
Some of the CLI / bootstrap tests have been moved to the extensions repo, since they were depending on them.