Add retry cycles for deleting stack resources#7717
Merged
dominikschubert merged 2 commits intomasterfrom Feb 21, 2023
Merged
Conversation
steffyP
reviewed
Feb 20, 2023
Member
steffyP
left a comment
There was a problem hiding this comment.
Thanks for jumping on this so quickly! 🔝
I tested the use case for RDS cluster/instance locally, and it works 😄
however, some of the tests in the CI are failing now for stack.destroy()😞
steffyP
approved these changes
Feb 20, 2023
Member
steffyP
left a comment
There was a problem hiding this comment.
LGTM 👍 😄
Running/Deleting the rds-stack sample locally seems to work, and there are no more test failures 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@steffyP found an issue with stack deletion when deleting a stack that contains resources with dependencies
#7703 (comment)
Changes
DELETE_COMPLETEstate.The loop is similar to the core deployment loop we already have. This retry now allows that first an independent resource is deleted and the dependent one is retried up to 10 times which is usually enough for the old one to be deleted as well.
There are of course still a few issues but they are quite out of scope like doing this asynchronously and not primarily relying on the loop, but instead using the resource graph.