Allow configuration of docker image used for port checks#7690
Merged
Conversation
whummer
approved these changes
Feb 15, 2023
Member
There was a problem hiding this comment.
Nice catch, LGTM! 👍
I've noticed we are also using the DOCKER_IMAGE_NAME (localstack/localstack) in other places as well.
Should we maybe make these constants configurable as well? 🤔
+1 - let's collect any references to custom image names, and make them configurable in a central place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7681
Changes
Now allows overriding the default image that is used internally in ECS to verify we can open ports with a docker container. Previously this was statically set to
localstack/localstackand some users might not have access to that image in their environment.Discussion
I've noticed we are also using the DOCKER_IMAGE_NAME (
localstack/localstack) in other places as well.Should we maybe make these constants configurable as well? 🤔