refactor state visitor code and lifecycle hooks#7650
Merged
Conversation
716cc23 to
6554e81
Compare
Member
Author
|
pro tests actually passed as well |
6554e81 to
bb8c0d8
Compare
giograno
approved these changes
Feb 13, 2023
Member
giograno
left a comment
There was a problem hiding this comment.
All good! Thanks for kicking this off!
| def is_enabled(self): | ||
| return True | ||
|
|
||
| def accept_state_visitor(self, visitor: StateVisitor): |
bb8c0d8 to
4695139
Compare
4695139 to
d2d5769
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes some minor refactoring (mostly moving and renaming) of code related to persistence, state, and the visitors.
localstack.statefor the state API (which are the base abstractions for disk-based persistence and pods)StateLifecyleHookthat will be used in the futureServiceLifecycleHookextend from thatServiceimplement theaccept_state_visitor(pre-requisite for follow-up code)BackendStateLifecycle(nowStateLifecycleHookas originally intended)