Conversation
20510e1 to
e1a855b
Compare
e1a855b to
80e3132
Compare
80e3132 to
0b13c24
Compare
0b13c24 to
57c9169
Compare
dominikschubert
approved these changes
Feb 14, 2023
Member
dominikschubert
left a comment
There was a problem hiding this comment.
LGTM, thanks for addressing this.
1 minor question regarding the snapshot construction. Not blocking the merge though
Comment on lines
+541
to
+542
| resource_types = set([event["ResourceType"] for event in events]) | ||
| snapshot.match("resource_types", dict.fromkeys(resource_types, 0)) |
Member
There was a problem hiding this comment.
Any reason to not just use the set or a sorted list of the types? 🤔
Member
Author
There was a problem hiding this comment.
didn't occurred to me 😅
608cb1c to
18165e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change the CFn Api returns the correct resource type in the stack events. Important for cli tools that rely in the stack events for progress indicators.