Push to localstack/localstack-pro, and deprecate localstack/localstack-light and localstack/localstack-full#7249
Merged
alexrashed merged 21 commits intorelease/v1.3from Nov 30, 2022
Merged
Conversation
silv-io
commented
Nov 28, 2022
silv-io
commented
Nov 28, 2022
b61c0ca to
ff5d437
Compare
77875b2 to
fe8af07
Compare
2 tasks
f3e2f7a to
875514d
Compare
fe8af07 to
dbfd7d3
Compare
875514d to
49a5f6a
Compare
dbfd7d3 to
e61dd3d
Compare
49a5f6a to
4d614e7
Compare
e61dd3d to
6709848
Compare
4d614e7 to
8902bb0
Compare
a1b1ab4 to
9788198
Compare
localstack/localstack-pro localstack/localstack-pro and deprecate localstack/localstack-light and localstack/localstack-full
localstack/localstack-pro and deprecate localstack/localstack-light and localstack/localstack-fulllocalstack/localstack-pro, and deprecate localstack/localstack-light and localstack/localstack-full
8902bb0 to
d8ef83c
Compare
dbb356e to
630e0d2
Compare
e025b03 to
ddf2c91
Compare
95896df to
81fff31
Compare
ddf2c91 to
0b56790
Compare
81fff31 to
628ab16
Compare
0b56790 to
63ecd84
Compare
c57a8ba to
2ab28dc
Compare
alexrashed
approved these changes
Nov 30, 2022
Member
alexrashed
left a comment
There was a problem hiding this comment.
Nice! The makefile is currently quite messy, this is great work, thanks! 🚀
|
|
||
| # base-full: Stage which adds additional dependencies to avoid installing them at runtime (f.e. elasticsearch) | ||
| # FIXME deprecated | ||
| FROM unmarked as unmarked-full |
Member
There was a problem hiding this comment.
Unfortunately, this means that we elasticsearch download stages are executed on every build. But the full image is being deprecated with 1.3.0.
If we see a significant increase in the build time or an increasing instability of the build pipeline, we have two options:
- Push the light version for the full version (it's deprecated and will be removed, elasticsearch versions are downloaded on demand). This could break the environment for users which cannot download elasticsearch on-demand or expect it to be present in the image.
- We could further optimize this by creating a new builder stage from which we only copy the final result / downloaded ES version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comparison of pipeline duration:
In total - depending on the caching behaviour in the build - the pipeline could take around 5-15 minutes longer on master builds.
This can probably be circumvented by downloading the elasticsearch dependencies in its own builder step and just copying them into the step where the version gets marked. This way we can cache the Elasticsearch dependencies in a deeper layer (before our code) and avoid downloading them almost every time.