Add parity between old and new lambda provider for destinations#7231
Merged
dominikschubert merged 6 commits intomasterfrom Nov 23, 2022
Merged
Add parity between old and new lambda provider for destinations#7231dominikschubert merged 6 commits intomasterfrom
dominikschubert merged 6 commits intomasterfrom
Conversation
8109fc5 to
e242ccc
Compare
50f181c to
678c378
Compare
dfangl
approved these changes
Nov 23, 2022
Member
dfangl
left a comment
There was a problem hiding this comment.
Just some minor comments/questions
Comment on lines
+3
to
+8
| There are a few well-defined ways to control this function: | ||
|
|
||
| 1. event echo response (default) | ||
| 2. blocking wait mode | ||
| 3. fail mode | ||
| 4. forwarding to SNS |
Member
There was a problem hiding this comment.
I do not think any of this works with this function?
Co-authored-by: Daniel Fangl <daniel.fangl@localstack.cloud>
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will still need a lot of work after the initial release but should for now have parity with the existing implementation in the old non-ASF provider.