Add CRUD support for lambda layers#7204
Merged
dominikschubert merged 13 commits intomasterfrom Nov 23, 2022
Merged
Conversation
390b84d to
1f82451
Compare
09fe126 to
627b7c7
Compare
dfangl
requested changes
Nov 23, 2022
| all_layer_versions = [] | ||
| for layer in state.layers.values(): | ||
| if ( | ||
| layer_name in layer.arn |
Member
There was a problem hiding this comment.
Is this really a substring match? Can I list the layer versions of the layer "arn" and get the first one?
The API spec says its the name or arn, could we just extract the name and access by its key?
steffyP
approved these changes
Nov 23, 2022
Member
steffyP
left a comment
There was a problem hiding this comment.
I'm only reviewing the snapshot/transformer changes as I don't have any experience with lambda layers :)
Transfomers LGTM, should be fine if the tests pass 👍
dfangl
approved these changes
Nov 23, 2022
6fe374c to
e68e146
Compare
9564093 to
1f72cc6
Compare
…ode of the layer available in the executors
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds basic CRUD support for lambda layers into the community offering.
This is only a superficial CRUD-based simulation, i.e. the code won't actually be mounted into the lambda. (This feature is reserved for LocalStack PRO.)