add S3 ASF test job to CircleCI workflow#7173
Merged
alexrashed merged 1 commit intomasterfrom Nov 17, 2022
Merged
Conversation
9977b09 to
a0601ac
Compare
steffyP
approved these changes
Nov 17, 2022
Member
steffyP
left a comment
There was a problem hiding this comment.
LGTM! 👍 thanks for adding the s3-asf test to the workflow! 🙏
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new parallel step to our CircleCI workflow to test the S3 ASF provider on every build.
It depends on #7081 (fixes the remaining tests for the new S3 ASF provider).
It should be reverted once the new S3 provider is default (such that the legacy provider is tested).
Finally, the tests should be removed when the legacy providers are removed.