Skip to content

migrate S3 presign tests#7070

Merged
thrau merged 7 commits intomasterfrom
s3-presign-test-migration
Nov 13, 2022
Merged

migrate S3 presign tests#7070
thrau merged 7 commits intomasterfrom
s3-presign-test-migration

Conversation

@steffyP
Copy link
Member

@steffyP steffyP commented Oct 21, 2022 •
edited
Loading

S3 presign test migration and cleanup

In this PR two remaining presigned-tests are migrated to tests/integration/s3/test_s3.py and the old tests/integration/test_s3.py is removed.

  • The test test_presign_check_signature_validation_for_port_permutation is marked with xfail now, as it still needs a fix. This fix will be resolved in a separate PR.

  • Some other tests related to presigned-post, that are flaky in the CI have been set to xfail or skip some validation.

  • removed xfail for test test_put_and_get_object_with_content_language_disposition and replaced it with a skip_snapshot_verify for now.

TODO:

  • rebase with master and remove commits from s3-migration branch
  • link follow-up PR with fix for test_presign_check_signature_validation_for_port_permutation

@steffyP steffyP temporarily deployed to localstack-ext-tests October 21, 2022 19:14 Inactive
@steffyP steffyP mentioned this pull request Oct 21, 2022
Merged
21 tasks
@github-actions
Copy link

github-actions bot commented Oct 21, 2022 •
edited
Loading

LocalStack integration with Pro

       3 files  ±0         3 suites  ±0   1h 22m 56s ⏱️ +18s
1 441 tests +1  1 243 ✔️  - 1  198 💤 +2  0 ❌ ±0 
2 039 runs  +1  1 609 ✔️  - 1  430 💤 +2  0 ❌ ±0 

Results for commit 702c853. ± Comparison against base commit 21ca0e9.

♻️ This comment has been updated with latest results.

@bentsku bentsku temporarily deployed to localstack-ext-tests October 24, 2022 12:04 Inactive
@steffyP steffyP force-pushed the s3-presign-test-migration branch from 6f774de to c9ed298 Compare October 31, 2022 14:03
@steffyP steffyP temporarily deployed to localstack-ext-tests October 31, 2022 14:03 Inactive
@steffyP steffyP temporarily deployed to localstack-ext-tests October 31, 2022 14:59 Inactive
@steffyP
Copy link
Member Author

steffyP commented Oct 31, 2022

all checks were successful with the commits from s3-migration.
Rebasing now with master to ensure the tests are still working with the old provider.

@steffyP steffyP force-pushed the s3-presign-test-migration branch from 015f8e5 to 702c853 Compare October 31, 2022 17:39
@steffyP steffyP temporarily deployed to localstack-ext-tests October 31, 2022 17:39 Inactive
@steffyP steffyP changed the title S3 presign test migration migrate S3 presign tests Oct 31, 2022
@steffyP steffyP marked this pull request as ready for review October 31, 2022 17:41
@steffyP steffyP requested a review from thrau as a code owner October 31, 2022 17:41
@steffyP steffyP mentioned this pull request Nov 2, 2022
Merged
@bentsku bentsku mentioned this pull request Nov 9, 2022
Merged
thrau
thrau approved these changes Nov 13, 2022
View reviewed changes
Copy link
Member

@thrau thrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@thrau thrau merged commit fb05ada into master Nov 13, 2022
@thrau thrau deleted the s3-presign-test-migration branch November 13, 2022 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thrau thrau thrau approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@steffyP @thrau @bentsku