Discover lambda runtime executor using plugins#7034
Merged
Conversation
dominikschubert
approved these changes
Oct 17, 2022
Member
dominikschubert
left a comment
There was a problem hiding this comment.
some nits, otherwise LGTM 👍
localstack/services/awslambda/invocation/runtime_executor_plugin.py
Outdated
Show resolved
Hide resolved
localstack/services/awslambda/invocation/runtime_executor_plugin.py
Outdated
Show resolved
Hide resolved
localstack/services/awslambda/invocation/runtime_executor_plugin.py
Outdated
Show resolved
Hide resolved
localstack/services/awslambda/invocation/runtime_executor_plugin.py
Outdated
Show resolved
Hide resolved
thrau
requested changes
Oct 17, 2022
Member
thrau
left a comment
There was a problem hiding this comment.
Looks mostly good to me! The plugin should move into its own module though (see explanation in the comments).
localstack/services/awslambda/invocation/runtime_executor_plugin.py
Outdated
Show resolved
Hide resolved
localstack/services/awslambda/invocation/runtime_executor_plugin.py
Outdated
Show resolved
Hide resolved
…ntime executor plugin def to own plugins file
thrau
reviewed
Oct 18, 2022
| @@ -0,0 +1,12 @@ | |||
| from localstack.services.awslambda.invocation.runtime_executor import RuntimeExecutorPlugin | |||
Member
There was a problem hiding this comment.
we're still importing this entire import path when we start localstack. which includes the lambda API, and everything under localstack.services.awslambda.invocation.lambda_models.
could we just move the RuntimeExecutorPlugin class here as well, to make sure we have no other imports?
Member
Author
There was a problem hiding this comment.
Ah, you are of course right. My assumption as that runtime_executor would not import anything as well, but of course it does for the types.
cmoralesmx
pushed a commit
to cmoralesmx/localstack
that referenced
this pull request
Oct 24, 2022
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The lambda runtime executor class can now be configured and is loadable using the plux plugin mechanism.
Also introduced an abc to specify the interface for runtime executors.
Introduced configuration options
LAMBDA_RUNTIME_EXECUTOR: Specify the runtime executor using its plugin name. Will make it possible to switch to another executor (like kubernetes or static executor) specified as plugins.