Merged
Conversation
steffyP
reviewed
Nov 14, 2022
localstack/services/s3/provider.py
Outdated
| def s3_response_is_delete_keys(fn, self): | ||
| """ | ||
| Old provider had a fix for a ticket, concerning 'x-id' - there is no documentation on AWS about this, but it is probably still valid | ||
| Additional fix for testing if this is a "delete_objects" request, by removing trailing "=" from the path |
Member
There was a problem hiding this comment.
The docs about "Additional fix ..." is now obsolete and should be removed.
But it would be great if we kept a comment referencing the issue (#3931) that requires this patch
Merged
Member
Author
|
can't test the pro stuff yet, we need to merge and release ext in a broken state. but at least community works so far. i'll do the release dance |
0c556d5 to
86a2b43
Compare
alexrashed
pushed a commit
that referenced
this pull request
Nov 29, 2022
Co-authored-by: Cesar Alvernaz <cesar.alvernaz@gmail.com> Co-authored-by: Stefanie Plieschnegger <stefanie.plieschnegger@localstack.cloud>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades moto-ext to 4.0.10.post1, which builds on the recent 4.0.10 release
Adapted our patches/imports affected by