Skip to content

[breaking] Use edge as single entry point; performance improvements; forward requests in-memory instead of opening port per service#2905

Merged
whummer merged 13 commits intomasterfrom
fix-perf
Sep 15, 2020
Merged

[breaking] Use edge as single entry point; performance improvements; forward requests in-memory instead of opening port per service#2905
whummer merged 13 commits intomasterfrom
fix-perf

Conversation

@whummer
Copy link
Member

@whummer whummer commented Aug 30, 2020 •
edited
Loading

Note: ⚠️ This is a breaking change - after this change, services are no longer accessible via the legacy service ports, but ONLY via the edge port ⚠️

This PR introduces a couple of performance improvements which aim to improve the startup time and reduce the overall resource usage/footprint (e.g., less open network ports).

  • Forward edge requests in-memory instead of opening port per service
  • Remove proxies and backend ports where not needed anymore
  • Apply basic time profiling to provide some insights into the performance of different parts of the startup procedure.

@whummer whummer force-pushed the fix-perf branch 12 times, most recently from 8b29b86 to 26a3c08 Compare August 31, 2020 16:39
@coveralls
Copy link

coveralls commented Aug 31, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.08%) to 75.469% when pulling e79c947 on fix-perf into 80bf4f6 on master.

@whummer whummer changed the title [w.i.p.] Performance improvements; forward edge requests in-memory instead of opening port per service Performance improvements; forward edge requests in-memory instead of opening port per service Aug 31, 2020
@whummer whummer changed the title Performance improvements; forward edge requests in-memory instead of opening port per service Use edge as single entry point; performance improvements; forward requests in-memory instead of opening port per service Aug 31, 2020
@whummer whummer changed the title Use edge as single entry point; performance improvements; forward requests in-memory instead of opening port per service [breaking] Use edge as single entry point; performance improvements; forward requests in-memory instead of opening port per service Sep 3, 2020
@whummer whummer force-pushed the fix-perf branch 2 times, most recently from 8d1e831 to abf557f Compare September 6, 2020 16:51
@whummer whummer mentioned this pull request Sep 7, 2020
Merged
@whummer whummer merged commit 8e92b76 into master Sep 15, 2020
@whummer whummer deleted the fix-perf branch September 15, 2020 21:41
@whummer whummer mentioned this pull request Sep 15, 2020
Closed
@williamfalconeruk williamfalconeruk mentioned this pull request Sep 22, 2020
Merged
4 tasks
@sahussaimc sahussaimc mentioned this pull request Oct 6, 2020
Closed
civitaspo added a commit to civitaspo/embulk-output-s3_parquet that referenced this pull request Oct 12, 2020
@civitaspo
Use 4566 port for localstack/localstack s3 service ref. localstack/lo…
ae75874 
…calstack#2905
civitaspo added a commit to civitaspo/embulk-output-s3_parquet that referenced this pull request Oct 12, 2020
@civitaspo
Use 4566 port for localstack/localstack s3 service ref. localstack/lo…
248ba32 
…calstack#2905
civitaspo added a commit to civitaspo/embulk-output-s3_parquet that referenced this pull request Oct 12, 2020
@civitaspo
Use 4566 port for localstack/localstack s3 service ref. localstack/lo…
7a7e081 
…calstack#2905
@civitaspo civitaspo mentioned this pull request Oct 12, 2020
Merged
@mxxk mxxk mentioned this pull request Oct 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@whummer @coveralls