Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

[SFN][TestState] Add test for invalid state machine definition in test state call#13446

Merged
tiurin merged 1 commit into
mainfrom
sfn/feat/test-state-state-name-validation
Dec 4, 2025
Merged

[SFN][TestState] Add test for invalid state machine definition in test state call#13446
tiurin merged 1 commit into
mainfrom
sfn/feat/test-state-state-name-validation

Conversation

@tiurin

@tiurin tiurin commented Dec 1, 2025

Copy link
Copy Markdown
Contributor

Ignoring the exact validation message for now

Motivation

Add tests for failure modes.

Closes DRG-133.

Changes

Adds a test for invalid state machine definition in test state call.

ANTLR parser message has different wording but the same meaning as AWS response. Not investing time now to convert to the exact same wording - relying on error code for test.

Tests

Related

@tiurin tiurin requested a review from gregfurman December 1, 2025 17:14
@tiurin tiurin added semver: patch Non-breaking changes which can be included in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes aws:stepfunctions AWS Step Functions labels Dec 1, 2025
@github-actions

github-actions Bot commented Dec 1, 2025 •
edited
Loading

Copy link
Copy Markdown

Test Results - Preflight, Unit

22 889 tests  ±0   21 075 ✅ ±0   6m 31s ⏱️ +5s
     1 suites ±0    1 814 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit fd25c20. ± Comparison against base commit cb8043c.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Dec 1, 2025 •
edited
Loading

Copy link
Copy Markdown

LocalStack Community integration with Pro

    2 files  ±    0      2 suites  ±0   22m 8s ⏱️ - 1h 33m 13s
1 712 tests  - 3 400  1 623 ✅  - 3 097  89 💤  - 303  0 ❌ ±0 
1 714 runs   - 3 400  1 623 ✅  - 3 097  91 💤  - 303  0 ❌ ±0 

Results for commit fd25c20. ± Comparison against base commit cb8043c.

This pull request removes 3401 and adds 1 tests. Note that renamed tests count towards both. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

tests.aws.services.stepfunctions.v2.test_state.test_test_state_machine_scenarios.TestStateMachineScenarios ‑ test_state_name_invalid_state_definition

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Dec 1, 2025 •
edited
Loading

Copy link
Copy Markdown

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 3s ⏱️ +4s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit fd25c20. ± Comparison against base commit cb8043c.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Dec 1, 2025 •
edited
Loading

Copy link
Copy Markdown

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   38m 58s ⏱️
1 736 tests 1 648 ✅ 88 💤 0 ❌
1 742 runs  1 648 ✅ 94 💤 0 ❌

Results for commit fd25c20.

♻️ This comment has been updated with latest results.

@tiurin
Add test for invalid state machine definition in test state call
fd25c20 
Ignoring the exact validation message for now
@tiurin tiurin force-pushed the sfn/feat/test-state-state-name-validation branch from 3004b16 to fd25c20 Compare December 4, 2025 12:18
@tiurin tiurin merged commit b8e33ce into main Dec 4, 2025
42 checks passed
@tiurin tiurin deleted the sfn/feat/test-state-state-name-validation branch December 4, 2025 13:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@gregfurman gregfurman gregfurman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

aws:stepfunctions AWS Step Functions docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tiurin @gregfurman