🐛 fix(skill): stop OAuth connectors duplicating into the Skills tab#15510
Merged
ONLY-yours merged 1 commit intoJun 8, 2026
Merged
Conversation
The unified /settings/skill manager renders the Connectors and Skills sub-tabs from one SkillList via viewMode. Lobehub/Klavis OAuth connectors (type 'lobehub' | 'klavis') belong only in the Connectors view, but the Skills view's "Community Skill" section still mapped them alongside the market agent skills — so Gmail, Notion, Google Drive, etc. showed up in both tabs. Render only market agent skills in the Skills view; OAuth connectors stay exclusively under the Connectors view's "OAuth Connectors" group. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
@ONLY-yours is attempting to deploy a commit to the LobeHub OSS Team on Vercel. A member of the Team first needs to authorize it. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## canary #15510 +/- ##
=========================================
Coverage 70.64% 70.64%
=========================================
Files 3274 3274
Lines 322959 322934 -25
Branches 29419 34147 +4728
=========================================
- Hits 228155 228148 -7
+ Misses 94621 94603 -18
Partials 183 183
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ONLY-yours
added a commit
that referenced
this pull request
Jun 9, 2026
Reconcile the klavis→composio migration with the new Connectors system (custom OAuth MCP connectors) that landed on canary via #15546. Conflict resolutions (keep connector additions + apply composio rename): - AgentManagementContextInjector: plugin type union → 'builtin' | 'composio' | 'lobehub-skill' | 'custom' - contextEngineering: keep COMPOSIO_APP_TYPES + canary's isDesktop import - useControls / SkillList: keep composioStore + connectorSelectors; drop renamed klavisStore; community OAuth connectors live only in the Connectors view (canary dedup, #15510) - aiAgent: keep both ComposioService and deviceGateway imports Follow-on fixes for the now-merged tree: - execAgent.connectorOverlap.test: mock @/server/services/composio (klavis service removed) - finish incomplete rename in some consumers: servers→composioServers, serverName→label; composio.createConnection now returns authConfigId for the optimistic store entry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💻 Change Type
🔀 Description of Change
The unified
/settings/skillmanager renders the Connectors and Skills sub-tabs from a singleSkillListdriven byviewMode. Lobehub/Klavis OAuth connectors (type: 'lobehub' | 'klavis'— Gmail, Notion, Google Drive, Google Calendar, GitHub, Linear, etc.) are meant to live only in the Connectors view's "OAuth Connectors" group.However, the Skills view's "Community Skill" (
社区 Skill) section still mappedcommunitySkillItemsalongside the market agent skills, so every OAuth connector appeared in both tabs.This PR makes the Skills view render only
marketAgentSkills(xlsx, pdf, docx, skill-creator, …). OAuth connectors stay exclusively under the Connectors view.Two changes in
src/routes/(main)/settings/skill/features/SkillList.tsx:hasCommunitySkillsno longer keys offcommunitySkillItems.length, onlymarketAgentSkills.length.communitySkillssection renders justrenderMarketAgentSkills(); the lobehub/klavis branch is removed.🧪 How to Test
Open
/settings/skill:📝 Additional Information
Regression from #15463 (Connectors system). The code already documented the intent (
// Lobehub/Klavis OAuth skills go in Connectors tab), but the skill-view render path was left in place.