⬆️ chore(deps): bump @lobehub/ui to 5.15.1#15214
Merged
Merged
Conversation
5.15.1 adds `&[data-has-header] { padding-block-start: 0 }` and
`&[data-has-footer] { padding-block-end: 0 }` on the menu popup, so the
4px block padding the slot content used to bleed into no longer exists.
Drop the `margin-block-*: -4px` compensations on the Plus menu's tools
search box, stats footer, and knowledge "view more" button to avoid
content being clipped by the popup's `overflow: hidden`.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## canary #15214 +/- ##
========================================
Coverage 70.93% 70.93%
========================================
Files 3153 3153
Lines 314704 314704
Branches 27741 28659 +918
========================================
Hits 223242 223242
Misses 91294 91294
Partials 168 168
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
hardy-one
pushed a commit
to hardy-one/lobehub
that referenced
this pull request
May 27, 2026
5.15.1 adds `&[data-has-header] { padding-block-start: 0 }` and
`&[data-has-footer] { padding-block-end: 0 }` on the menu popup, so the
4px block padding the slot content used to bleed into no longer exists.
Drop the `margin-block-*: -4px` compensations on the Plus menu's tools
search box, stats footer, and knowledge "view more" button to avoid
content being clipped by the popup's `overflow: hidden`.
5 tasks
Innei
added a commit
that referenced
this pull request
Jun 1, 2026
…#15391) The skill market dropdown's settings button navigates to /settings/skill but does not close the controlled dropdown first, so the popup persists after the trigger has unmounted (LOBE-9852). Also restore the negative margins on the skill market footer (regressed in #15214 when bumping @lobehub/ui to 5.15.1) so the stats row aligns with the dropdown's outer padding. Apply the same defensive close-before-navigate to ModelSwitchPanel: - ListItemRenderer no-provider / empty-model rows previously navigated without calling onClose at all. - Footer and GenerationListItemRenderer now close before navigate instead of after, for a consistent ordering. Closes LOBE-9852
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💻 Change Type
🔀 Description of Change
Bump `@lobehub/ui` from `^5.14.1` to `^5.15.1`.
5.15.1 migrates `ContextMenu`/`DropdownMenu` to base-ui primitives and tightens the menu density. The relevant breaking detail for our code is in the menu popup style: it now self-trims its block padding whenever a header/footer slot is present —
```css
&[data-has-header] { padding-block-start: 0; }
&[data-has-footer] { padding-block-end: 0; }
```
The Plus action menu (`src/features/ChatInput/ActionBar/Plus/index.tsx`) feeds header/footer slot content via `useToolsControls` and `useKnowledgeControls`. Those contents used `margin-block-*: -4px` to bleed into the popup's 4px block padding. With that padding now 0, the negative margins push content outside the popup and the new `popupWithSlots` rule `overflow: hidden` clips it.
Dropped the now-obsolete compensations:
Inline-axis compensations are kept — popup inline padding is unchanged.
🧪 How to Test
Open the chat input `+` menu:
Hover the Tools entry → check the submenu's search bar (header) sits inside the popup with normal spacing, no clipping.
In the same submenu, scroll to bottom → check the stats footer (pin/auto counts + settings) is fully visible.
Hover the Knowledge Base entry → check the "View more" button (footer) sits flush at the bottom without being cut off.
Tested locally
Added/updated tests
No tests needed