🔥 chore: drop task template tracking#14666
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 45587cea9f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## canary #14666 +/- ##
==========================================
- Coverage 60.84% 60.77% -0.07%
==========================================
Files 2274 2271 -3
Lines 197745 197268 -477
Branches 22008 21936 -72
==========================================
- Hits 120317 119893 -424
+ Misses 77416 77363 -53
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Member
Author
|
@codex review latest code |
|
Codex Review: Didn't find any major issues. 👍 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
2 tasks
The recommendation surface is about to be redesigned, so the analytics funnel added in #14517 is being removed up front. A fresh tracking schema will land alongside the redesigned UI. - Delete `analytics.ts` plus its test and the tracking-focused `TaskTemplateCard.test.tsx`. - Drop `RecommendedTaskTemplate` / `TaskTemplateRecommendationSource` / `TaskTemplateFallbackPool` and revert the service to plain `TaskTemplate[]`. - Strip impression, dismiss, create-clicked/result and skill-connect-clicked/result calls from `TaskTemplateCard.tsx`, while keeping the createTask + navigate-to-task flow from #14540. - Remove `recommendationBatchId` / `userInterestCount` / `onCreated` plumbing from `useDailyBriefRecommendationsUI`, `DailyBriefRecommendationsView`, and the card props. - Revert `useSkillConnection` to the pre-tracking variant (no onConnectResult / SkillConnectionResult).
After #14540 changed the create-task flow to auto-navigate to `/task/{id}`, removing the `onCreated` plumbing from #14517 in the same sweep meant the SWR recommendation cache was never mutated on success. Combined with the server-side `recordCreated` being a no-op and `listDailyRecommend` not excluding created IDs, returning to Home showed the same recommendation as actionable again — letting users trigger duplicate scheduled tasks from the same template. Re-add the minimal cache-eviction plumbing (no analytics): - TaskTemplateCard exposes `onCreated` and calls it on success - useDailyBriefRecommendationsUI shares `removeTemplateFromList` for both dismiss and created flows - DailyBriefRecommendationsView passes `onCreated` through
c893d77 to
faa65de
Compare
emaxlele
pushed a commit
to emaxlele/lobehub
that referenced
this pull request
May 11, 2026
* 🔥 chore: drop task template tracking The recommendation surface is about to be redesigned, so the analytics funnel added in lobehub#14517 is being removed up front. A fresh tracking schema will land alongside the redesigned UI. - Delete `analytics.ts` plus its test and the tracking-focused `TaskTemplateCard.test.tsx`. - Drop `RecommendedTaskTemplate` / `TaskTemplateRecommendationSource` / `TaskTemplateFallbackPool` and revert the service to plain `TaskTemplate[]`. - Strip impression, dismiss, create-clicked/result and skill-connect-clicked/result calls from `TaskTemplateCard.tsx`, while keeping the createTask + navigate-to-task flow from lobehub#14540. - Remove `recommendationBatchId` / `userInterestCount` / `onCreated` plumbing from `useDailyBriefRecommendationsUI`, `DailyBriefRecommendationsView`, and the card props. - Revert `useSkillConnection` to the pre-tracking variant (no onConnectResult / SkillConnectionResult). * 🐛 fix: remove created template from recommendation cache After lobehub#14540 changed the create-task flow to auto-navigate to `/task/{id}`, removing the `onCreated` plumbing from lobehub#14517 in the same sweep meant the SWR recommendation cache was never mutated on success. Combined with the server-side `recordCreated` being a no-op and `listDailyRecommend` not excluding created IDs, returning to Home showed the same recommendation as actionable again — letting users trigger duplicate scheduled tasks from the same template. Re-add the minimal cache-eviction plumbing (no analytics): - TaskTemplateCard exposes `onCreated` and calls it on success - useDailyBriefRecommendationsUI shares `removeTemplateFromList` for both dismiss and created flows - DailyBriefRecommendationsView passes `onCreated` through
emaxlele
pushed a commit
to emaxlele/lobehub
that referenced
this pull request
May 11, 2026
* 🔥 chore: drop task template tracking The recommendation surface is about to be redesigned, so the analytics funnel added in lobehub#14517 is being removed up front. A fresh tracking schema will land alongside the redesigned UI. - Delete `analytics.ts` plus its test and the tracking-focused `TaskTemplateCard.test.tsx`. - Drop `RecommendedTaskTemplate` / `TaskTemplateRecommendationSource` / `TaskTemplateFallbackPool` and revert the service to plain `TaskTemplate[]`. - Strip impression, dismiss, create-clicked/result and skill-connect-clicked/result calls from `TaskTemplateCard.tsx`, while keeping the createTask + navigate-to-task flow from lobehub#14540. - Remove `recommendationBatchId` / `userInterestCount` / `onCreated` plumbing from `useDailyBriefRecommendationsUI`, `DailyBriefRecommendationsView`, and the card props. - Revert `useSkillConnection` to the pre-tracking variant (no onConnectResult / SkillConnectionResult). * 🐛 fix: remove created template from recommendation cache After lobehub#14540 changed the create-task flow to auto-navigate to `/task/{id}`, removing the `onCreated` plumbing from lobehub#14517 in the same sweep meant the SWR recommendation cache was never mutated on success. Combined with the server-side `recordCreated` being a no-op and `listDailyRecommend` not excluding created IDs, returning to Home showed the same recommendation as actionable again — letting users trigger duplicate scheduled tasks from the same template. Re-add the minimal cache-eviction plumbing (no analytics): - TaskTemplateCard exposes `onCreated` and calls it on success - useDailyBriefRecommendationsUI shares `removeTemplateFromList` for both dismiss and created flows - DailyBriefRecommendationsView passes `onCreated` through
emaxlele
pushed a commit
to emaxlele/lobehub
that referenced
this pull request
May 11, 2026
* 🔥 chore: drop task template tracking The recommendation surface is about to be redesigned, so the analytics funnel added in lobehub#14517 is being removed up front. A fresh tracking schema will land alongside the redesigned UI. - Delete `analytics.ts` plus its test and the tracking-focused `TaskTemplateCard.test.tsx`. - Drop `RecommendedTaskTemplate` / `TaskTemplateRecommendationSource` / `TaskTemplateFallbackPool` and revert the service to plain `TaskTemplate[]`. - Strip impression, dismiss, create-clicked/result and skill-connect-clicked/result calls from `TaskTemplateCard.tsx`, while keeping the createTask + navigate-to-task flow from lobehub#14540. - Remove `recommendationBatchId` / `userInterestCount` / `onCreated` plumbing from `useDailyBriefRecommendationsUI`, `DailyBriefRecommendationsView`, and the card props. - Revert `useSkillConnection` to the pre-tracking variant (no onConnectResult / SkillConnectionResult). * 🐛 fix: remove created template from recommendation cache After lobehub#14540 changed the create-task flow to auto-navigate to `/task/{id}`, removing the `onCreated` plumbing from lobehub#14517 in the same sweep meant the SWR recommendation cache was never mutated on success. Combined with the server-side `recordCreated` being a no-op and `listDailyRecommend` not excluding created IDs, returning to Home showed the same recommendation as actionable again — letting users trigger duplicate scheduled tasks from the same template. Re-add the minimal cache-eviction plumbing (no analytics): - TaskTemplateCard exposes `onCreated` and calls it on success - useDailyBriefRecommendationsUI shares `removeTemplateFromList` for both dismiss and created flows - DailyBriefRecommendationsView passes `onCreated` through
Closed
Coooolfan
pushed a commit
to Coooolfan/lobehub
that referenced
this pull request
May 12, 2026
* 🔥 chore: drop task template tracking The recommendation surface is about to be redesigned, so the analytics funnel added in lobehub#14517 is being removed up front. A fresh tracking schema will land alongside the redesigned UI. - Delete `analytics.ts` plus its test and the tracking-focused `TaskTemplateCard.test.tsx`. - Drop `RecommendedTaskTemplate` / `TaskTemplateRecommendationSource` / `TaskTemplateFallbackPool` and revert the service to plain `TaskTemplate[]`. - Strip impression, dismiss, create-clicked/result and skill-connect-clicked/result calls from `TaskTemplateCard.tsx`, while keeping the createTask + navigate-to-task flow from lobehub#14540. - Remove `recommendationBatchId` / `userInterestCount` / `onCreated` plumbing from `useDailyBriefRecommendationsUI`, `DailyBriefRecommendationsView`, and the card props. - Revert `useSkillConnection` to the pre-tracking variant (no onConnectResult / SkillConnectionResult). * 🐛 fix: remove created template from recommendation cache After lobehub#14540 changed the create-task flow to auto-navigate to `/task/{id}`, removing the `onCreated` plumbing from lobehub#14517 in the same sweep meant the SWR recommendation cache was never mutated on success. Combined with the server-side `recordCreated` being a no-op and `listDailyRecommend` not excluding created IDs, returning to Home showed the same recommendation as actionable again — letting users trigger duplicate scheduled tasks from the same template. Re-add the minimal cache-eviction plumbing (no analytics): - TaskTemplateCard exposes `onCreated` and calls it on success - useDailyBriefRecommendationsUI shares `removeTemplateFromList` for both dismiss and created flows - DailyBriefRecommendationsView passes `onCreated` through
Innei
pushed a commit
to Innei/lobehub
that referenced
this pull request
May 12, 2026
* 🔥 chore: drop task template tracking The recommendation surface is about to be redesigned, so the analytics funnel added in lobehub#14517 is being removed up front. A fresh tracking schema will land alongside the redesigned UI. - Delete `analytics.ts` plus its test and the tracking-focused `TaskTemplateCard.test.tsx`. - Drop `RecommendedTaskTemplate` / `TaskTemplateRecommendationSource` / `TaskTemplateFallbackPool` and revert the service to plain `TaskTemplate[]`. - Strip impression, dismiss, create-clicked/result and skill-connect-clicked/result calls from `TaskTemplateCard.tsx`, while keeping the createTask + navigate-to-task flow from lobehub#14540. - Remove `recommendationBatchId` / `userInterestCount` / `onCreated` plumbing from `useDailyBriefRecommendationsUI`, `DailyBriefRecommendationsView`, and the card props. - Revert `useSkillConnection` to the pre-tracking variant (no onConnectResult / SkillConnectionResult). * 🐛 fix: remove created template from recommendation cache After lobehub#14540 changed the create-task flow to auto-navigate to `/task/{id}`, removing the `onCreated` plumbing from lobehub#14517 in the same sweep meant the SWR recommendation cache was never mutated on success. Combined with the server-side `recordCreated` being a no-op and `listDailyRecommend` not excluding created IDs, returning to Home showed the same recommendation as actionable again — letting users trigger duplicate scheduled tasks from the same template. Re-add the minimal cache-eviction plumbing (no analytics): - TaskTemplateCard exposes `onCreated` and calls it on success - useDailyBriefRecommendationsUI shares `removeTemplateFromList` for both dismiss and created flows - DailyBriefRecommendationsView passes `onCreated` through
emaxlele
pushed a commit
to emaxlele/lobehub
that referenced
this pull request
May 12, 2026
* 🔥 chore: drop task template tracking The recommendation surface is about to be redesigned, so the analytics funnel added in lobehub#14517 is being removed up front. A fresh tracking schema will land alongside the redesigned UI. - Delete `analytics.ts` plus its test and the tracking-focused `TaskTemplateCard.test.tsx`. - Drop `RecommendedTaskTemplate` / `TaskTemplateRecommendationSource` / `TaskTemplateFallbackPool` and revert the service to plain `TaskTemplate[]`. - Strip impression, dismiss, create-clicked/result and skill-connect-clicked/result calls from `TaskTemplateCard.tsx`, while keeping the createTask + navigate-to-task flow from lobehub#14540. - Remove `recommendationBatchId` / `userInterestCount` / `onCreated` plumbing from `useDailyBriefRecommendationsUI`, `DailyBriefRecommendationsView`, and the card props. - Revert `useSkillConnection` to the pre-tracking variant (no onConnectResult / SkillConnectionResult). * 🐛 fix: remove created template from recommendation cache After lobehub#14540 changed the create-task flow to auto-navigate to `/task/{id}`, removing the `onCreated` plumbing from lobehub#14517 in the same sweep meant the SWR recommendation cache was never mutated on success. Combined with the server-side `recordCreated` being a no-op and `listDailyRecommend` not excluding created IDs, returning to Home showed the same recommendation as actionable again — letting users trigger duplicate scheduled tasks from the same template. Re-add the minimal cache-eviction plumbing (no analytics): - TaskTemplateCard exposes `onCreated` and calls it on success - useDailyBriefRecommendationsUI shares `removeTemplateFromList` for both dismiss and created flows - DailyBriefRecommendationsView passes `onCreated` through
arvinxx
pushed a commit
that referenced
this pull request
May 12, 2026
* 🔥 chore: drop task template tracking The recommendation surface is about to be redesigned, so the analytics funnel added in #14517 is being removed up front. A fresh tracking schema will land alongside the redesigned UI. - Delete `analytics.ts` plus its test and the tracking-focused `TaskTemplateCard.test.tsx`. - Drop `RecommendedTaskTemplate` / `TaskTemplateRecommendationSource` / `TaskTemplateFallbackPool` and revert the service to plain `TaskTemplate[]`. - Strip impression, dismiss, create-clicked/result and skill-connect-clicked/result calls from `TaskTemplateCard.tsx`, while keeping the createTask + navigate-to-task flow from #14540. - Remove `recommendationBatchId` / `userInterestCount` / `onCreated` plumbing from `useDailyBriefRecommendationsUI`, `DailyBriefRecommendationsView`, and the card props. - Revert `useSkillConnection` to the pre-tracking variant (no onConnectResult / SkillConnectionResult). * 🐛 fix: remove created template from recommendation cache After #14540 changed the create-task flow to auto-navigate to `/task/{id}`, removing the `onCreated` plumbing from #14517 in the same sweep meant the SWR recommendation cache was never mutated on success. Combined with the server-side `recordCreated` being a no-op and `listDailyRecommend` not excluding created IDs, returning to Home showed the same recommendation as actionable again — letting users trigger duplicate scheduled tasks from the same template. Re-add the minimal cache-eviction plumbing (no analytics): - TaskTemplateCard exposes `onCreated` and calls it on success - useDailyBriefRecommendationsUI shares `removeTemplateFromList` for both dismiss and created flows - DailyBriefRecommendationsView passes `onCreated` through
lezi-fun
pushed a commit
to lezi-fun/lobehub
that referenced
this pull request
May 13, 2026
* 🔥 chore: drop task template tracking The recommendation surface is about to be redesigned, so the analytics funnel added in lobehub#14517 is being removed up front. A fresh tracking schema will land alongside the redesigned UI. - Delete `analytics.ts` plus its test and the tracking-focused `TaskTemplateCard.test.tsx`. - Drop `RecommendedTaskTemplate` / `TaskTemplateRecommendationSource` / `TaskTemplateFallbackPool` and revert the service to plain `TaskTemplate[]`. - Strip impression, dismiss, create-clicked/result and skill-connect-clicked/result calls from `TaskTemplateCard.tsx`, while keeping the createTask + navigate-to-task flow from lobehub#14540. - Remove `recommendationBatchId` / `userInterestCount` / `onCreated` plumbing from `useDailyBriefRecommendationsUI`, `DailyBriefRecommendationsView`, and the card props. - Revert `useSkillConnection` to the pre-tracking variant (no onConnectResult / SkillConnectionResult). * 🐛 fix: remove created template from recommendation cache After lobehub#14540 changed the create-task flow to auto-navigate to `/task/{id}`, removing the `onCreated` plumbing from lobehub#14517 in the same sweep meant the SWR recommendation cache was never mutated on success. Combined with the server-side `recordCreated` being a no-op and `listDailyRecommend` not excluding created IDs, returning to Home showed the same recommendation as actionable again — letting users trigger duplicate scheduled tasks from the same template. Re-add the minimal cache-eviction plumbing (no analytics): - TaskTemplateCard exposes `onCreated` and calls it on success - useDailyBriefRecommendationsUI shares `removeTemplateFromList` for both dismiss and created flows - DailyBriefRecommendationsView passes `onCreated` through
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💻 Change Type
🔗 Related Issue
Reverts the analytics added in #14517. Closes LOBE-8727 (impression dedupe key bug — no longer relevant once tracking is removed; will be redesigned along with the new surface).
🔀 Description of Change
The Task Template recommendation surface is about to be redesigned, so the analytics funnel added in #14517 is being removed now. A fresh tracking schema will land alongside the new UI.
analytics.tsplus its test and the tracking-focusedTaskTemplateCard.test.tsx.RecommendedTaskTemplate/TaskTemplateRecommendationSource/TaskTemplateFallbackPooland revert the service to plainTaskTemplate[].TaskTemplateCard.tsx, while keeping thecreateTask+ navigate-to-task flow introduced in ✨ feat: Agent Task System available #14540.recommendationBatchId/userInterestCount/onCreatedplumbing fromuseDailyBriefRecommendationsUI,DailyBriefRecommendationsView, and the card props.useSkillConnectionto the pre-tracking variant (noonConnectResult/SkillConnectionResult).🧪 How to Test
```bash
bunx vitest run --silent='passed-only' 'src/server/services/taskTemplate/index.test.ts'
```
Result: 16 tests passed.
📸 Screenshots / Videos
N/A — analytics-only removal. Recommendation card render and create-task flow stay identical.
📝 Additional Information
No PostHog dashboards are deleted in this PR. The previously instrumented events (
task_template_list_served,task_template_card_impression,task_template_dismissed,task_template_create_clicked,task_template_create_result,task_template_skill_connect_clicked,task_template_skill_connect_result) will simply stop firing.