🐛 fix(conversation): prevent synthetic scroll from shrinking spacer#14584
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## canary #14584 +/- ##
=========================================
Coverage 66.18% 66.18%
=========================================
Files 2899 2899
Lines 253977 253979 +2
Branches 30854 24835 -6019
=========================================
+ Hits 168085 168089 +4
+ Misses 85739 85737 -2
Partials 153 153
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
emaxlele
pushed a commit
to emaxlele/lobehub
that referenced
this pull request
May 12, 2026
…obehub#14584) 🐛 fix: prevent synthetic scroll from shrinking spacer
arvinxx
pushed a commit
that referenced
this pull request
May 12, 2026
…14584) 🐛 fix: prevent synthetic scroll from shrinking spacer
lezi-fun
pushed a commit
to lezi-fun/lobehub
that referenced
this pull request
May 13, 2026
…obehub#14584) 🐛 fix: prevent synthetic scroll from shrinking spacer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💻 Change Type
🔗 Related Issue
Fixes LOBE-8626
🔀 Description of Change
useConversationScroll.🧪 How to Test
Commands run:
TDD red check was confirmed by temporarily restoring the old condition; the new regression test failed with
{ cancelPin: true, shrinkSpacer: true }before the fix and passed after restoring the user-intent gate.Full E2E execution was not run in this checkout because the harness starts
next start, and there is no local.nextproduction build in the workspace.📸 Screenshots / Videos
N/A
📝 Additional Information
The E2E scenario avoids
mouse.wheel()deliberately. It mutatesscrollTopand dispatches ascrollevent directly to simulate virtual-list or layout correction offset changes without any user wheel/touch/key/pointer input.