Skip to content

🐛 fix: add temporary email auth error locale#14564

Merged
tjx666 merged 3 commits into
canaryfrom
fix/auth-error-temporary-email-i18n
May 9, 2026
Merged

🐛 fix: add temporary email auth error locale#14564
tjx666 merged 3 commits into
canaryfrom
fix/auth-error-temporary-email-i18n

Conversation

@tjx666

@tjx666 tjx666 commented May 9, 2026

Copy link
Copy Markdown
Member

💻 Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 👷 build
  • ⚡️ perf
  • ✅ test
  • 📝 docs
  • 🔨 chore

🔗 Related Issue

Related to LOBE-8656

🔀 Description of Change

  • Add the TEMPORARY_EMAIL_NOT_ALLOWED auth error translation key.
  • Provide the English default locale and zh-CN preview translation so auth pages can display a localized signup warning instead of falling back to the raw backend message.

🧪 How to Test

  • Tested locally
  • Added/updated tests
  • No tests needed
bun run type-check

📸 Screenshots / Videos

Before After
N/A N/A

📝 Additional Information

No runtime behavior changes in OSS; this only adds a reusable auth error locale key.

@vercel

vercel Bot commented May 9, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
lobehub Ready Ready Preview, Comment May 9, 2026 10:32am

Request Review

@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. feature:auth Authentication and authorization i18n labels May 9, 2026

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0c44e6bca1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread locales/zh-CN/authError.json Outdated
"codes.RATE_LIMIT_EXCEEDED": "请求过于频繁,请稍后再试",
"codes.SESSION_EXPIRED": "会话已过期,请重新登录",
"codes.SOCIAL_ACCOUNT_ALREADY_LINKED": "这个社交账号已被其他用户绑定,请使用其他账号",
"codes.TEMPORARY_EMAIL_NOT_ALLOWED": "暂不支持使用临时邮箱注册。请改用常规邮箱;重复尝试可能导致当前网络被限制。",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Regenerate the en-US entry locale

This zh-CN preview string is not durable unless the matching source JSON is updated too. The repo’s i18n entry is locales/en-US (.i18nrc.js), and scripts/i18nWorkflow/genDiff.ts compares that entry file against src/locales/default and unsets changed paths from output locales before genDefaultLocale rewrites en-US; because locales/en-US/authError.json still lacks codes.TEMPORARY_EMAIL_NOT_ALLOWED, the next pnpm i18n run will treat this as a new default key and remove the committed zh-CN translation. Please add the same key to locales/en-US/authError.json or run the workflow as part of this change.

Useful? React with 👍 / 👎.

@codecov

codecov Bot commented May 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.86%. Comparing base (793a8de) to head (37c008d).
⚠️ Report is 3 commits behind head on canary.

Additional details and impacted files
@@           Coverage Diff            @@
##           canary   #14564    +/-   ##
========================================
  Coverage   68.86%   68.86%            
========================================
  Files        2634     2634            
  Lines      232130   232130            
  Branches    24626    23774   -852     
========================================
  Hits       159859   159859            
  Misses      72121    72121            
  Partials      150      150            
Flag Coverage Δ
app 63.53% <ø> (ø)
database 91.98% <ø> (ø)
packages/agent-runtime 80.50% <ø> (ø)
packages/builtin-tool-lobe-agent 83.41% <ø> (ø)
packages/context-engine 83.93% <ø> (ø)
packages/conversation-flow 92.43% <ø> (ø)
packages/file-loaders 87.60% <ø> (ø)
packages/memory-user-memory 74.74% <ø> (ø)
packages/model-bank 99.94% <ø> (ø)
packages/model-runtime 83.72% <ø> (ø)
packages/prompts 70.16% <ø> (ø)
packages/python-interpreter 92.90% <ø> (ø)
packages/ssrf-safe-fetch 0.00% <ø> (ø)
packages/types 4.86% <ø> (ø)
packages/utils 88.02% <ø> (ø)
packages/web-crawler 88.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Store 66.90% <ø> (ø)
Services 54.16% <ø> (ø)
Server 70.62% <ø> (ø)
Libs 54.03% <ø> (ø)
Utils 79.95% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tjx666 tjx666 merged commit c374892 into canary May 9, 2026
34 of 35 checks passed
@tjx666 tjx666 deleted the fix/auth-error-temporary-email-i18n branch May 9, 2026 10:50
@arvinxx arvinxx mentioned this pull request May 12, 2026
Innei pushed a commit to Innei/lobehub that referenced this pull request May 12, 2026
lezi-fun pushed a commit to lezi-fun/lobehub that referenced this pull request May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature:auth Authentication and authorization i18n size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant