Skip to content

👷 build: disable pnpm gvs for desktop ci#14357

Merged
Innei merged 9 commits into
canaryfrom
fix/pnpm11-desktop-ci
May 1, 2026
Merged

👷 build: disable pnpm gvs for desktop ci#14357
Innei merged 9 commits into
canaryfrom
fix/pnpm11-desktop-ci

Conversation

@Innei

@Innei Innei commented Apr 30, 2026

Copy link
Copy Markdown
Member

Summary

  • Disable pnpm global virtual store for desktop code quality install jobs
  • Apply the same setting to shared desktop build setup and isolated desktop install with hoisted linker
  • Increase Node heap for desktop setup install to avoid pnpm 11 lockfile parsing OOM
  • Mark desktop native dependencies as externally handled so electron-builder skips the pnpm node module collector that hits EMFILE on Linux

Verification

  • pnpm --dir apps/desktop type-check
  • pnpm --dir apps/desktop build:main
  • CI=true pnpm install --config.enable-global-virtual-store=false && bun run lint
  • git diff --check
  • GitHub Desktop PR Build setup passed after the heap change; latest upstream-branch PR run will validate Linux packaging without fork approval

Fixes the failure from https://github.com/lobehub/lobehub/actions/runs/25171952306/job/73793671549
Supersedes #14356, which used a fork branch and required manual workflow approval.

@vercel

vercel Bot commented Apr 30, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
lobehub Ready Ready Preview, Comment Apr 30, 2026 6:21pm

Request Review

@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Apr 30, 2026
@Innei Innei mentioned this pull request Apr 30, 2026
Closed
@dosubot dosubot Bot added electron Electron/Desktop app specific trigger:build-desktop Trigger Desktop build labels Apr 30, 2026
sourcery-ai[bot]
sourcery-ai Bot reviewed Apr 30, 2026
View reviewed changes

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine

@dosubot dosubot Bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Apr 30, 2026
@codecov

codecov Bot commented Apr 30, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.89%. Comparing base (506bb7b) to head (1a8d513).
⚠️ Report is 8 commits behind head on canary.

Additional details and impacted files 
@@            Coverage Diff             @@
##           canary   #14357      +/-   ##
==========================================
+ Coverage   68.88%   68.89%   +0.01%     
==========================================
  Files        2388     2388              
  Lines      208849   208886      +37     
  Branches    25324    21836    -3488     
==========================================
+ Hits       143861   143918      +57     
+ Misses      64846    64826      -20     
  Partials      142      142
Flag Coverage Δ
app 62.40% <ø> (+0.02%) ⬆️
database 92.29% <ø> (ø)
packages/agent-runtime 79.93% <ø> (ø)
packages/context-engine 83.87% <ø> (ø)
packages/conversation-flow 92.40% <ø> (ø)
packages/file-loaders 87.60% <ø> (ø)
packages/memory-user-memory 74.74% <ø> (ø)
packages/model-bank 99.94% <ø> (ø)
packages/model-runtime 83.79% <ø> (ø)
packages/prompts 67.98% <ø> (ø)
packages/python-interpreter 92.90% <ø> (ø)
packages/ssrf-safe-fetch 0.00% <ø> (ø)
packages/utils 87.84% <ø> (ø)
packages/web-crawler 88.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Store 66.56% <100.00%> (+0.08%) ⬆️
Services 53.62% <ø> (ø)
Server 69.27% <ø> (+<0.01%) ⬆️
Libs 53.27% <ø> (ø)
Utils 79.95% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

🚀 Desktop App Build Completed!

Version: 0.0.0-nightly.pr14357.10107
Build Time: 2026-04-30T18:41:52.405Z

📦 Release Download · 📥 Actions Artifacts

Build Artifacts

Platform File Size
macOS (Apple Silicon) LobeHub-Nightly-0.0.0-nightly.pr14357.10107-arm64-mac.zip 144.69 MB
macOS (Apple Silicon) LobeHub-Nightly-0.0.0-nightly.pr14357.10107-arm64.dmg 138.50 MB
macOS (Intel) LobeHub-Nightly-0.0.0-nightly.pr14357.10107-mac.zip 153.34 MB
macOS (Intel) LobeHub-Nightly-0.0.0-nightly.pr14357.10107-x64.dmg 145.72 MB
Windows LobeHub-Nightly-0.0.0-nightly.pr14357.10107-setup.exe 132.28 MB
Linux LobeHub-Nightly-0.0.0-nightly.pr14357.10107.AppImage 162.42 MB

Warning

Note: This is a temporary build for testing purposes only.

@Innei Innei merged commit 948ba5e into canary May 1, 2026
38 checks passed
@Innei Innei deleted the fix/pnpm11-desktop-ci branch May 1, 2026 05:17
@Innei Innei mentioned this pull request May 1, 2026
Merged
Innei added a commit that referenced this pull request May 1, 2026
@Innei
⏪ revert: revert pnpm v11 migration (#14372)
c9b4493 
* Revert "👷 build: disable pnpm gvs for desktop ci (#14357)"

This reverts commit 948ba5e.

* Revert "👷 build(repo): migrate to pnpm v11 and consolidate workspace config (#14316)"

This reverts commit 1d9b609.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

Assignees

No one assigned

Labels

electron Electron/Desktop app specific size:M This PR changes 30-99 lines, ignoring generated files. trigger:build-desktop Trigger Desktop build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Innei