🐛 fix(user-state): include notification settings in getUserState#14257
Merged
Conversation
The notification column existed in user_settings schema and was being written by updateSettings, but getUserState's select query never read it back. As a result, after refresh the notification settings page displayed the default (defaults from DEFAULT_NOTIFICATION_SETTINGS) instead of the user's saved values. Add `settingsNotification` to the select and surface it as `settings.notification` in the returned state.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
sxueck
pushed a commit
to sxueck/lobehub
that referenced
this pull request
Apr 28, 2026
mutoe
pushed a commit
to mutoe/lobehub
that referenced
this pull request
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💻 Change Type
🔀 Description of Change
UserModel.getUserStateselects every settings column exceptnotification. The column is correctly written byupdateSetting, but the read path silently drops it, sodata.settings.notificationis alwaysundefinedafter refresh. The notification settings page then re-renders withDEFAULT_NOTIFICATION_SETTINGS, making it look like the user's toggle was never saved.Add
settingsNotification: userSettings.notificationto the select list and surface it assettings.notificationin the returned state.🧪 How to Test
/settings/notification(cloud app).