Skip to content

📝 docs(skills): rename code-review to review-checklist#14229

Merged
tjx666 merged 1 commit into
canaryfrom
feat/rename-review-checklist
Apr 27, 2026
Merged

📝 docs(skills): rename code-review to review-checklist#14229
tjx666 merged 1 commit into
canaryfrom
feat/rename-review-checklist

Conversation

@tjx666

@tjx666 tjx666 commented Apr 27, 2026

Copy link
Copy Markdown
Member

💻 Change Type

  • 📝 docs

🔗 Related Issue

N/A

🔀 Description of Change

Reposition the code-review skill as a recurring-mistakes checklist (not a generic review guide), and rename the directory + skill name accordingly.

  • Drop the "Before You Start" prelude — review-plus already handles the scan-related reads.
  • Drop the "Output Format" trailing block — describes a local-CLI flow no longer used.
  • Collapse the redundant ## Checklist wrapper and promote subsection headers from ### to ##.
  • Add a ### Code Review section in AGENTS.md pointing to the renamed skill.
  • Correct the pnpm i18n note: it is slow and run manually before a PR, not auto-handled by CI.

🧪 How to Test

  • No tests needed

📝 Additional Information

A companion cloud-repo PR updates the matching symlink and adds a cloud-review-checklist skill (cloud-only i18n locale-key trap).

Reposition the skill as a recurring-mistakes checklist:

- drop the "Before You Start" prelude and "Output Format" trailing block
- promote subsection headers from ### to ##
- update AGENTS.md to reference the renamed skill from a new "Code Review" section
- correct the i18n note: pnpm i18n is slow and run manually, not auto-handled by CI
@vercel

vercel Bot commented Apr 27, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
lobehub Building Building Preview, Comment Apr 27, 2026 10:11am

Request Review

@dosubot dosubot Bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Apr 27, 2026

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine

@codecov

codecov Bot commented Apr 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.07%. Comparing base (f32fff1) to head (60762c8).
⚠️ Report is 4 commits behind head on canary.

Additional details and impacted files
@@             Coverage Diff             @@
##           canary   #14229       +/-   ##
===========================================
- Coverage   86.03%   68.07%   -17.97%     
===========================================
  Files         620     2266     +1646     
  Lines       51652   194266   +142614     
  Branches     8719    20337    +11618     
===========================================
+ Hits        44440   132242    +87802     
- Misses       7083    61895    +54812     
  Partials      129      129               
Flag Coverage Δ
app 61.56% <ø> (?)
database 92.03% <ø> (-0.01%) ⬇️
packages/agent-runtime 79.93% <ø> (ø)
packages/context-engine 83.25% <ø> (ø)
packages/conversation-flow 92.40% <ø> (ø)
packages/file-loaders 87.02% <ø> (ø)
packages/memory-user-memory 74.74% <ø> (ø)
packages/model-bank 99.89% <ø> (ø)
packages/model-runtime 84.29% <ø> (+<0.01%) ⬆️
packages/prompts 68.17% <ø> (ø)
packages/python-interpreter 92.90% <ø> (ø)
packages/ssrf-safe-fetch 0.00% <ø> (ø)
packages/utils 88.41% <ø> (ø)
packages/web-crawler 88.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Store 67.20% <ø> (∅)
Services 53.36% <ø> (∅)
Server 68.43% <57.29%> (∅)
Libs 53.30% <ø> (∅)
Utils 80.04% <ø> (-13.43%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tjx666 tjx666 merged commit 9acb128 into canary Apr 27, 2026
36 of 38 checks passed
@tjx666 tjx666 deleted the feat/rename-review-checklist branch April 27, 2026 10:17
sxueck pushed a commit to sxueck/lobehub that referenced this pull request Apr 28, 2026
mutoe pushed a commit to mutoe/lobehub that referenced this pull request May 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant