💄 style(tasks): drop custom actions on result briefs & show trigger tag in subtasks#14226
Merged
Conversation
…g in subtasks - Result briefs render a fixed single-button UI, so reject custom actions at brief creation time and remove the unused defaults / lifecycle actions. - Surface automation trigger (heartbeat / schedule) on subtask rows by threading the fields through TaskService → TaskDetailSubtask → tree. - Polish: tree title flex/overflow fix, QueueTray send icon swapped to ArrowUp. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## canary #14226 +/- ##
===========================================
- Coverage 86.03% 68.07% -17.97%
===========================================
Files 620 2262 +1642
Lines 51652 194173 +142521
Branches 8719 24260 +15541
===========================================
+ Hits 44440 132181 +87741
- Misses 7083 61863 +54780
Partials 129 129
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
sxueck
pushed a commit
to sxueck/lobehub
that referenced
this pull request
Apr 28, 2026
…ag in subtasks (lobehub#14226) ✨ feat(tasks): drop custom actions on result briefs & show trigger tag in subtasks - Result briefs render a fixed single-button UI, so reject custom actions at brief creation time and remove the unused defaults / lifecycle actions. - Surface automation trigger (heartbeat / schedule) on subtask rows by threading the fields through TaskService → TaskDetailSubtask → tree. - Polish: tree title flex/overflow fix, QueueTray send icon swapped to ArrowUp. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
mutoe
pushed a commit
to mutoe/lobehub
that referenced
this pull request
May 1, 2026
…ag in subtasks (lobehub#14226) ✨ feat(tasks): drop custom actions on result briefs & show trigger tag in subtasks - Result briefs render a fixed single-button UI, so reject custom actions at brief creation time and remove the unused defaults / lifecycle actions. - Surface automation trigger (heartbeat / schedule) on subtask rows by threading the fields through TaskService → TaskDetailSubtask → tree. - Polish: tree title flex/overflow fix, QueueTray send icon swapped to ArrowUp. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💻 Change Type
🔗 Related Issue
Follow-up to #14208.
🔀 Description of Change
BriefService.resolveto complete the task, so anyactionsarray on a result brief was silently ignored. Reject them at the source: drop theresultentry fromDEFAULT_BRIEF_ACTIONS, forceactions = nullin the server runtime whentype === 'result', and remove the now-dead custom action list from the lifecycle's max-iteration brief. The tool manifest description now calls out this constraint so the agent stops emitting actions it never gets credit for.automationMode/heartbeat.interval/schedule.{pattern,timezone}throughTaskService → TaskDetailSubtaskand renderedTaskTriggerTagnext to the subtask name when the subtask runs in heartbeat / schedule mode. Tree title now flexes/overflows correctly so long names truncate without pushing the tag offscreen.QueueTraysend icon swapped toArrowUpfor consistency with the main composer.🧪 How to Test
Tested locally
Added/updated tests
No tests needed
Trigger an auto-review with
maxIterationsreached → confirm the urgent result brief renders the fixed approve button only (no retry/feedback custom actions).Have an agent emit a
briefCreatewithtype: 'result'and a customactionsarray → confirm the brief is created withactions = nullin DB.Open a task with subtasks running in heartbeat or schedule mode → confirm
TaskTriggerTagshows next to each subtask name and long names truncate cleanly.📸 Screenshots / Videos
📝 Additional Information
No DB migration. No breaking change for existing briefs (
actionscolumn already nullable).