⬆️ chore: upgrade desktop Electron to 41.3.0#14223
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## canary #14223 +/- ##
===========================================
+ Coverage 68.09% 86.03% +17.94%
===========================================
Files 2266 620 -1646
Lines 194349 51663 -142686
Branches 20344 7941 -12403
===========================================
- Hits 132338 44449 -87889
+ Misses 61882 7084 -54798
- Partials 129 130 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Member
Author
|
CI collect failure follow-up: Root cause: with no lockfile, CI resolved Fix pushed to this PR: add a pnpm patch for Local checks after the patch: pnpm install --offline
NODE_ENV=test bunx vitest run --silent=passed-only src/components/AntdStaticMethods/index.test.tsx
NODE_ENV=test bunx vitest run --silent=passed-only src/utils/identifier.test.tsBoth targeted suites pass locally. |
Member
Author
|
Update: verified the upstream @ant-design/icons 6.2.1 fix path.
Validation run:
|
Contributor
🚀 Desktop App Build Completed!Version: 📦 Release Download · 📥 Actions Artifacts Build Artifacts
Warning Note: This is a temporary build for testing purposes only. |
mutoe
pushed a commit
to mutoe/lobehub
that referenced
this pull request
May 1, 2026
* ⬆️ chore: upgrade desktop electron to 41.3.0 * 🐛 fix: patch ant design icons vitest resolution * 🐛 fix: require fixed ant design icons version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💻 Change Type
🔗 Related Issue
N/A
🔀 Description of Change
Upgrade the desktop app Electron dependency from
41.1.0to41.3.0, the latest stable Electron release checked during this change. This includes the 41.2.0 macOS menu logging fix that removed the repeatedrepresentedObject is not a WeakPtrToElectronMenuModelAsNSObjectmessage when interacting with macOS menus.This project intentionally does not use lock files, so no lockfile update is included.
🧪 How to Test
Local verification from the PR branch:
Also verified in the earlier local run that the desktop app reaches
Application ready state completedand logs did not containrepresentedObject is not a WeakPtrToElectronMenuModelAsNSObject. Full native macOS menu/tray click automation was blocked by missing Assistive Access permission in this environment.📸 Screenshots / Videos
N/A
📝 Additional Information
pnpm installreports existing baseline peer/deprecated warnings and an@upstash/qstashpatch warning unrelated to this Electron version bump.bun run build:maincompletes with existing Rolldown/Vite warnings.