Skip to content

🐛 fix(Action): model params panel closes unexpectedly during auto-save#14198

Merged
tjx666 merged 2 commits into
lobehub:canaryfrom
sxjeru:42667
Apr 27, 2026
Merged

🐛 fix(Action): model params panel closes unexpectedly during auto-save#14198
tjx666 merged 2 commits into
lobehub:canaryfrom
sxjeru:42667

Conversation

@sxjeru

@sxjeru sxjeru commented Apr 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

💻 Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 👷 build
  • ⚡️ perf
  • ✅ test
  • 📝 docs
  • 🔨 chore

🔗 Related Issue

🔀 Description of Change

add loading prop to ActionDropdown and ActionPopover components

目前该面板在保存时会消失，该 pr 修复此问题。

image

🧪 How to Test

  • Tested locally
  • Added/updated tests
  • No tests needed

📸 Screenshots / Videos

Before After
... ...

📝 Additional Information

Copilot AI review requested due to automatic review settings April 26, 2026 06:51
@vercel

vercel Bot commented Apr 26, 2026

Copy link
Copy Markdown

@sxjeru is attempting to deploy a commit to the LobeHub OSS Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Apr 26, 2026
@dosubot dosubot Bot added the 🐛 Bug label Apr 26, 2026
sourcery-ai[bot]
sourcery-ai Bot reviewed Apr 26, 2026
View reviewed changes

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine

@lobehubbot

lobehubbot commented Apr 26, 2026

Copy link
Copy Markdown
Member

@ONLY-yours - This is a bug fix in the ChatInput ActionBar area (model params panel closes unexpectedly during auto-save). Please take a look.

@codecov

codecov Bot commented Apr 26, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.85%. Comparing base (9b48e24) to head (ad8d465).
⚠️ Report is 4 commits behind head on canary.

Additional details and impacted files 
@@           Coverage Diff           @@
##           canary   #14198   +/-   ##
=======================================
  Coverage   67.84%   67.85%           
=======================================
  Files        2227     2227           
  Lines      191342   191366   +24     
  Branches    22952    22965   +13     
=======================================
+ Hits       129820   129843   +23     
- Misses      61393    61394    +1     
  Partials      129      129
Flag Coverage Δ
app 61.09% <ø> (+<0.01%) ⬆️
database 92.22% <ø> (ø)
packages/agent-runtime 79.82% <ø> (ø)
packages/context-engine 83.25% <ø> (ø)
packages/conversation-flow 92.40% <ø> (ø)
packages/file-loaders 87.02% <ø> (ø)
packages/memory-user-memory 74.74% <ø> (ø)
packages/model-bank 99.89% <ø> (ø)
packages/model-runtime 84.28% <ø> (+<0.01%) ⬆️
packages/prompts 70.14% <ø> (ø)
packages/python-interpreter 92.90% <ø> (ø)
packages/ssrf-safe-fetch 0.00% <ø> (ø)
packages/utils 88.41% <ø> (ø)
packages/web-crawler 88.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Store 67.21% <100.00%> (+0.02%) ⬆️
Services 53.36% <ø> (ø)
Server 67.60% <ø> (-0.01%) ⬇️
Libs 53.30% <ø> (ø)
Utils 80.04% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sxjeru
typo
ad8d465 
Co-authored-by: Copilot <copilot@github.com>
Copilot AI reviewed Apr 26, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@tjx666 tjx666 merged commit 6b95847 into lobehub:canary Apr 27, 2026
22 of 23 checks passed
@lobehubbot

lobehubbot commented Apr 27, 2026

Copy link
Copy Markdown
Member

❤️ Great PR @sxjeru ❤️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.

@sxjeru sxjeru deleted the 42667 branch April 27, 2026 23:38
sxueck pushed a commit to sxueck/lobehub that referenced this pull request Apr 28, 2026
@sxjeru @sxueck
🐛 fix(Action): model params panel closes unexpectedly during auto-save (
39c8d53 
lobehub#14198)

Co-authored-by: Copilot <copilot@github.com>
mutoe pushed a commit to mutoe/lobehub that referenced this pull request May 1, 2026
@sxjeru @mutoe
🐛 fix(Action): model params panel closes unexpectedly during auto-save (
1516182 
lobehub#14198)

Co-authored-by: Copilot <copilot@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

🐛 Bug size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sxjeru @lobehubbot @tjx666