😂 refactor(tasks): drop per-agent /agent/:aid/tasks routes again by arvinxx · Pull Request #14164 · lobehub/lobehub

arvinxx · 2026-04-25T09:25:32Z

Summary

PR ✨ feat(agent): add floating chat panel and workspace improvements #13887 reintroduced the per-agent Tasks surface (sidebar entry, route files, agentId-scoped breadcrumb/list/board, /agent/:aid/tasks/:taskId navigation) that ✨ feat(tasks): unified Tasks routes, detail polish & CC Agent streaming #14109 had explicitly removed in favor of unified /tasks and /task/:id.
Restore the unified-only model: drop the agent sidebar Tasks nav item, delete the agent-scoped route files, strip agent-tasks blocks from both desktopRouter configs, and revert the agentId props and per-agent navigate paths in AgentTasksPage / KanbanBoard / Breadcrumb / TaskDetailPage.
Preserves 💄 style(tasks): polish kanban columns, status labels, priority hotkeys #14137's canceled kanban column (only the agentId/URL parts were reverted in KanbanBoard.tsx).

Test plan

Open an agent chat — sidebar no longer shows the "任务 / Tasks" entry between 消息频道 and 定时任务
Navigate to /tasks — list/kanban still works, opens task detail at /task/:id
Navigate to /agent/<aid>/tasks directly — should 404 / fall through to error boundary (route gone)
Create a task from the unified /tasks list — created task opens at /task/:id, not /agent/.../tasks/:id
Kanban "Canceled" column from 💄 style(tasks): polish kanban columns, status labels, priority hotkeys #14137 still renders

🤖 Generated with Claude Code

PR #13887 reintroduced the per-agent Tasks surface (sidebar entry, route files, agentId-scoped breadcrumb/list/board, /agent/:aid/tasks/:taskId navigation) that #14109 had removed in favor of unified /tasks and /task/:id. Restore the unified-only model: drop the agent sidebar Tasks nav item, delete the agent-scoped route files, strip agent-tasks blocks from both desktopRouter configs, and revert the agentId props and per-agent navigate paths in AgentTasksPage / KanbanBoard / Breadcrumb / TaskDetailPage. Preserves #14137's canceled kanban column. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

vercel · 2026-04-25T09:25:37Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
lobehub	Ready	Preview, Comment	Apr 25, 2026 10:07am

sourcery-ai

Sorry @arvinxx, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

codecov · 2026-04-25T09:30:19Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.59%. Comparing base (01f6858) to head (5b1f6b1).
⚠️ Report is 1 commits behind head on canary.

Additional details and impacted files

@@           Coverage Diff           @@
##           canary   #14164   +/-   ##
=======================================
  Coverage   67.59%   67.59%           
=======================================
  Files        2192     2192           
  Lines      188963   188947   -16     
  Branches    23276    23274    -2     
=======================================
- Hits       127721   127717    -4     
+ Misses      61113    61101   -12     
  Partials      129      129

Flag	Coverage Δ
app	`60.62% <100.00%> (+<0.01%)`	⬆️
database	`92.22% <ø> (ø)`
packages/agent-runtime	`79.82% <ø> (ø)`
packages/context-engine	`83.23% <ø> (ø)`
packages/conversation-flow	`92.40% <ø> (ø)`
packages/file-loaders	`87.02% <ø> (ø)`
packages/memory-user-memory	`74.74% <ø> (ø)`
packages/model-bank	`99.89% <ø> (ø)`
packages/model-runtime	`84.27% <ø> (ø)`
packages/prompts	`70.14% <ø> (ø)`
packages/python-interpreter	`92.90% <ø> (ø)`
packages/ssrf-safe-fetch	`0.00% <ø> (ø)`
packages/utils	`88.41% <ø> (ø)`
packages/web-crawler	`88.66% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
Store	`67.15% <ø> (ø)`
Services	`53.24% <ø> (ø)`
Server	`66.63% <ø> (+<0.01%)`	⬆️
Libs	`53.30% <ø> (ø)`
Utils	`80.04% <ø> (ø)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bcb01e659e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

handleNewTopic only checked /profile and /channel, so on /agent/:aid/page, /agent/:aid/cron/:cronId or other sub-routes the redirect was skipped and mutate() opened a new topic on a non-chat screen — looking ineffective to the user. Match useTopicNavigation's pattern: derive an agent base path from params (with topicId when present) and treat anything longer than that as a sub-route, so adding new sub-routes never re-introduces this gap. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

The previous fix conditioned the redirect on isInAgentSubRoute, which left the URL untouched on /agent/:aid/:topicId — opening a new topic while the URL still pointed at the previous one. Drop the conditional and always push /agent/:aid: it covers every sub-route (/profile, /channel, /page, /cron/:cronId, …) and strips any stale :topicId so the URL matches the freshly opened topic. Restores Nav.test.tsx. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

) * 🔥 feat(tasks): drop per-agent /agent/:aid/tasks routes again PR #13887 reintroduced the per-agent Tasks surface (sidebar entry, route files, agentId-scoped breadcrumb/list/board, /agent/:aid/tasks/:taskId navigation) that #14109 had removed in favor of unified /tasks and /task/:id. Restore the unified-only model: drop the agent sidebar Tasks nav item, delete the agent-scoped route files, strip agent-tasks blocks from both desktopRouter configs, and revert the agentId props and per-agent navigate paths in AgentTasksPage / KanbanBoard / Breadcrumb / TaskDetailPage. Preserves #14137's canceled kanban column. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * 🐛 fix(agent): redirect any agent sub-route before opening new topic handleNewTopic only checked /profile and /channel, so on /agent/:aid/page, /agent/:aid/cron/:cronId or other sub-routes the redirect was skipped and mutate() opened a new topic on a non-chat screen — looking ineffective to the user. Match useTopicNavigation's pattern: derive an agent base path from params (with topicId when present) and treat anything longer than that as a sub-route, so adding new sub-routes never re-introduces this gap. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * 🐛 fix(agent): always push agent chat route before opening new topic The previous fix conditioned the redirect on isInAgentSubRoute, which left the URL untouched on /agent/:aid/:topicId — opening a new topic while the URL still pointed at the previous one. Drop the conditional and always push /agent/:aid: it covers every sub-route (/profile, /channel, /page, /cron/:cronId, …) and strips any stale :topicId so the URL matches the freshly opened topic. Restores Nav.test.tsx. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Apr 25, 2026

sourcery-ai Bot reviewed Apr 25, 2026

View reviewed changes

chatgpt-codex-connector Bot reviewed Apr 25, 2026

View reviewed changes

Comment thread src/routes/(main)/agent/_layout/Sidebar/Header/Nav.tsx Outdated

arvinxx and others added 2 commits April 25, 2026 17:36

vercel Bot deployed to Preview April 25, 2026 10:07 View deployment

arvinxx changed the title ~~🔥 feat(tasks): drop per-agent /agent/:aid/tasks routes again~~ 😂 refactor(tasks): drop per-agent /agent/:aid/tasks routes again Apr 25, 2026

arvinxx merged commit 61d27b4 into canary Apr 25, 2026
35 checks passed

arvinxx deleted the fix/remove-agent-task-menu branch April 25, 2026 10:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

😂 refactor(tasks): drop per-agent /agent/:aid/tasks routes again#14164

😂 refactor(tasks): drop per-agent /agent/:aid/tasks routes again#14164
arvinxx merged 3 commits into
canaryfrom
fix/remove-agent-task-menu

arvinxx commented Apr 25, 2026

Uh oh!

vercel Bot commented Apr 25, 2026 •

edited

Loading

Uh oh!

sourcery-ai Bot left a comment

Uh oh!

codecov Bot commented Apr 25, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

arvinxx commented Apr 25, 2026

Summary

Test plan

Uh oh!

vercel Bot commented Apr 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sourcery-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Apr 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

vercel Bot commented Apr 25, 2026 •

edited

Loading

codecov Bot commented Apr 25, 2026 •

edited

Loading