🔨 chore: split test-app shards and deprecate isOnboarded#13938
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
4 tasks
isOnboarded
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## canary #13938 +/- ##
=========================================
Coverage 66.78% 66.78%
=========================================
Files 2088 2088
Lines 177438 177438
Branches 21635 18252 -3383
=========================================
Hits 118502 118502
Misses 58812 58812
Partials 124 124
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
mrsimpson
pushed a commit
to mrsimpson/lobehub
that referenced
this pull request
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💻 Change Type
🔗 Related Issue
N/A
🔀 Description of Change
Two small unrelated cleanups bundled together per author preference:
test-appjob matrix from 2 shards to 3 shards to cut per-job wall time. Themerge-app-coveragejob already matches blob artifacts via theblob-report-*pattern, so no other workflow changes are needed.@deprecatedmarker to theisOnboardedcolumn onusersso IDE/TypeScript users get a strikethrough and in-editor hint when referencing it. No runtime behavior change — the column and default are preserved. Theonboarding/agentOnboardingJSONB columns below appear to be the newer onboarding model; the migration/replacement story is left to a follow-up.🧪 How to Test
CI will run the new 3-shard matrix automatically on this PR. Deprecation is purely editor-surface; TS compilation/runtime is unaffected.
📝 Additional Information
If we later want to drop the
isOnboardedcolumn, that should be a separate PR with a migration.