🐛 fix: add the lobehub cli oidc expreis should refresh aksk#13925
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2eed5053f6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## canary #13925 +/- ##
==========================================
+ Coverage 66.55% 66.92% +0.36%
==========================================
Files 2023 2059 +36
Lines 170888 175202 +4314
Branches 19835 21430 +1595
==========================================
+ Hits 113733 117249 +3516
- Misses 57031 57829 +798
Partials 124 124
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
sxueck
pushed a commit
to sxueck/lobehub
that referenced
this pull request
Apr 28, 2026
…13925) * fix: add the lobehub cli oidc expreis should refresh aksk * fix: add the buffer seconds
mutoe
pushed a commit
to mutoe/lobehub
that referenced
this pull request
May 1, 2026
…13925) * fix: add the lobehub cli oidc expreis should refresh aksk * fix: add the buffer seconds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💻 Change Type
Summary
lh connectlogin session expiringafter 7 days without auto-refresh
refreshes JWT 1 hour before expiry
auth_failedtoattempt token refresh before exiting
(handles expired token during
auto-reconnect)
token refresh in both
auth_expiredandauth_failedhandlersBackground
Three related issues were identified:
connectcalls
resolveToken()once at startup,never refreshes during the long-lived
WebSocket connection (Access Token TTL: 7
days)
GatewayClientauto-reconnect reuses theoriginal expired JWT →
auth_failed→process exits
auth_expiredis dead code —Gateway server defines the type but never
sends it
Test plan
auth_failedretrywith successful token refresh
auth_failedtestto await async handler
getValidTokenfrom../auth/refreshupdateTokenandreconnecttoGatewayClient mock
Closes LOBE-7303
🔗 Related Issue
🔀 Description of Change
🧪 How to Test
📸 Screenshots / Videos
📝 Additional Information