Skip to content

🐛 fix: add the lost tools into manual agent runtime mode#13918

Merged
ONLY-yours merged 6 commits into
canaryfrom
fix/toolsLostInManualMode
Apr 17, 2026
Merged

🐛 fix: add the lost tools into manual agent runtime mode#13918
ONLY-yours merged 6 commits into
canaryfrom
fix/toolsLostInManualMode

Conversation

@ONLY-yours

Copy link
Copy Markdown
Member

💻 Change Type

Problem

  1. Builtin agents lose all default tools in Manual mode —
    skipDefaultTools is set to true when isManualMode &&
    isBuiltinAgent, causing runtime-managed tools (skills,
    web-browsing, sandbox, memory) to be completely excluded
    for inbox and other builtin agents.
  2. Skills cannot be activated in Manual mode —
    activateSkill API only exists in lobe-activator, which is
    excluded by manualModeExcludeToolIds in Manual mode.
    lobe-skills (which remains available) has no activateSkill
    capability.
  3. Unselected skills still injected in Manual mode —
    <available_skills> lists all installed skills regardless
    of user selection, allowing LLM to activate skills the
    user didn't choose.

Changes

  • streamingExecutor.ts: Remove
    shouldSkipDefaultForBuiltin; Manual mode now uses
    excludeDefaultToolIds uniformly (only excludes activator +
    skill-store)
  • builtin-tool-activator: Remove activateSkill from
    manifest; update system prompt to reference lobe-skills
  • builtin-tool-skills: Add activateSkillApi to manifest;
    update system prompts (web + desktop) with activateSkill
    guidance
  • contextEngineering.ts: Filter enabledSkills by
    user-selected pluginIds in Manual mode

Closes LOBE-7180

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 👷 build
  • ⚡️ perf
  • ✅ test
  • 📝 docs
  • 🔨 chore

🔗 Related Issue

🔀 Description of Change

🧪 How to Test

  • Tested locally
  • Added/updated tests
  • No tests needed

📸 Screenshots / Videos

Before After
... ...

📝 Additional Information

@vercel

vercel Bot commented Apr 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
lobehub Ready Ready Preview, Comment Apr 17, 2026 8:57am

Request Review

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine

@codecov

codecov Bot commented Apr 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.92%. Comparing base (2824c82) to head (bd4f542).
⚠️ Report is 4 commits behind head on canary.

Additional details and impacted files
@@             Coverage Diff             @@
##           canary   #13918       +/-   ##
===========================================
- Coverage   86.06%   66.92%   -19.15%     
===========================================
  Files         599     2059     +1460     
  Lines       49886   175209   +125323     
  Branches     8534    21432    +12898     
===========================================
+ Hits        42934   117253    +74319     
- Misses       6828    57832    +51004     
  Partials      124      124               
Flag Coverage Δ
app 59.30% <75.00%> (?)
database 92.42% <ø> (ø)
packages/agent-runtime 79.72% <ø> (ø)
packages/context-engine 83.22% <ø> (ø)
packages/conversation-flow 92.36% <ø> (ø)
packages/file-loaders 87.02% <ø> (ø)
packages/memory-user-memory 74.74% <ø> (ø)
packages/model-bank 99.86% <ø> (ø)
packages/model-runtime 84.21% <ø> (ø)
packages/prompts 69.24% <ø> (ø)
packages/python-interpreter 92.90% <ø> (ø)
packages/ssrf-safe-fetch 0.00% <ø> (ø)
packages/utils 90.34% <ø> (ø)
packages/web-crawler 88.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Store 66.25% <100.00%> (∅)
Services 51.78% <70.00%> (∅)
Server 66.93% <ø> (∅)
Libs 51.35% <ø> (∅)
Utils 91.12% <ø> (-2.36%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: abe44c32f5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/builtin-tool-skills/src/systemRole.desktop.ts
@ONLY-yours ONLY-yours merged commit 828175f into canary Apr 17, 2026
34 checks passed
@ONLY-yours ONLY-yours deleted the fix/toolsLostInManualMode branch April 17, 2026 09:02
mrsimpson pushed a commit to mrsimpson/lobehub that referenced this pull request May 8, 2026
* fix: slove the manual mode cant use some builtin tools

* refactor: change the active skill tools from lobe-activtor to  lobe-skill tools

* fix: only inject the avaiable skill when use the auto mode

* fix: update the desktop tools skill

* fix: add the some test to ensure the builin tools will use in manual mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant