🐛 fix: show success status for tool calls with no return value#13905
Merged
Conversation
When a tool call completes without returning content, the status indicator was incorrectly showing a loading spinner instead of a success checkmark. This fix passes the isToolCalling operation state to StatusIndicator to correctly determine when a tool has finished executing. https://claude.ai/code/session_01EBaKqzVTeEmrUXgFdNk7WH
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## canary #13905 +/- ##
===========================================
- Coverage 86.06% 66.92% -19.15%
===========================================
Files 599 2059 +1460
Lines 49886 175202 +125316
Branches 8534 17305 +8771
===========================================
+ Hits 42934 117249 +74315
- Misses 6828 57829 +51001
Partials 124 124
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2a2971edfe
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <Flexbox allowShrink horizontal align={'center'} gap={6}> | ||
| <StatusIndicator | ||
| intervention={intervention} | ||
| isToolExecuting={isToolCalling} |
There was a problem hiding this comment.
Pass operation-only running state to the status indicator
StatusIndicator now marks empty-result calls as complete only when isToolExecuting === false, but this prop is wired to isToolCalling here, which includes the fallback from Tool/index.tsx (!result.content). For tools that validly finish with content: null/empty, that fallback remains true, so this new success path never runs and the spinner persists. Please pass the operation-derived flag (without the empty-content fallback) so no-return completions can actually render success.
Useful? React with 👍 / 👎.
Updated the logic for determining tool execution states in both the Tool and Inspector components. The changes ensure that the status indicator accurately reflects when a tool is actively processing, even if no result is returned. This prevents misleading loading indicators and enhances user experience during tool interactions. Signed-off-by: Innei <tukon479@gmail.com>
…onent Removed unnecessary semicolon from CircleLoading component in DocumentHistoryDiff to ensure proper rendering. This minor fix enhances code clarity and maintains JSX standards. Signed-off-by: Innei <tukon479@gmail.com>
…formance Updated the ModeSwitch test suite by removing unnecessary async/await patterns, simplifying the mock configuration, and ensuring consistent cleanup after each test. These changes enhance the clarity and efficiency of the test cases for the onboarding mode switch functionality. Signed-off-by: Innei <tukon479@gmail.com>
mrsimpson
added a commit
to mrsimpson/lobehub
that referenced
this pull request
May 8, 2026
…ub#13905) * 🐛 fix: show success status for tool calls with no return value When a tool call completes without returning content, the status indicator was incorrectly showing a loading spinner instead of a success checkmark. This fix passes the isToolCalling operation state to StatusIndicator to correctly determine when a tool has finished executing. https://claude.ai/code/session_01EBaKqzVTeEmrUXgFdNk7WH * 🐛 fix(conversation): improve tool execution status handling Updated the logic for determining tool execution states in both the Tool and Inspector components. The changes ensure that the status indicator accurately reflects when a tool is actively processing, even if no result is returned. This prevents misleading loading indicators and enhances user experience during tool interactions. Signed-off-by: Innei <tukon479@gmail.com> * 🐛 fix(DocumentHistoryDiff): correct JSX syntax for CircleLoading component Removed unnecessary semicolon from CircleLoading component in DocumentHistoryDiff to ensure proper rendering. This minor fix enhances code clarity and maintains JSX standards. Signed-off-by: Innei <tukon479@gmail.com> * 🐛 fix(ModeSwitch.test): refactor tests to improve readability and performance Updated the ModeSwitch test suite by removing unnecessary async/await patterns, simplifying the mock configuration, and ensuring consistent cleanup after each test. These changes enhance the clarity and efficiency of the test cases for the onboarding mode switch functionality. Signed-off-by: Innei <tukon479@gmail.com> --------- Signed-off-by: Innei <tukon479@gmail.com> Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.