🐛 fix(app): include working panel into Lab feature, minor fixes#13889
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Sorry @nekomeowww, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## canary #13889 +/- ##
========================================
Coverage 66.77% 66.78%
========================================
Files 2043 2045 +2
Lines 173962 174133 +171
Branches 20444 20461 +17
========================================
+ Hits 116163 116294 +131
- Misses 57675 57715 +40
Partials 124 124
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f1e38e07b8
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| if (enableAgentWorkingPanel) { | ||
| items.push({ | ||
| icon: <Icon icon={PanelRightOpen} />, | ||
| key: 'agent-workspace', | ||
| label: t('workingPanel.title'), | ||
| onClick: () => toggleRightPanel(), | ||
| }, | ||
| { | ||
| checked: wideScreen, | ||
| icon: <Icon icon={Maximize2} />, | ||
| key: 'full-width', | ||
| label: t('viewMode.fullWidth'), | ||
| onCheckedChange: toggleWideScreen, | ||
| type: 'switch', | ||
| }, | ||
| ], | ||
| [t, tPortal, wideScreen, toggleRightPanel, toggleWideScreen, toggleNotebook], | ||
| ); | ||
| }); |
There was a problem hiding this comment.
Enforce lab flag on all working-panel entrypoints
This change only gates the header dropdown item, so disabling enableAgentWorkingPanel does not actually disable the feature: the global right-panel hotkey still calls toggleRightPanel() (see src/hooks/useHotkeys/globalScope.ts) and Conversation still mounts the working sidebar, so users can reopen the panel even when the Lab switch is off. If the Labs toggle is meant to control availability, this creates inconsistent behavior and makes the setting ineffective.
Useful? React with 👍 / 👎.
…hub#13889) * 🐛 fix(app): include working panel into Lab feature, minor fixes * 🐛 fix(app): conditional disabled.
💻 Change Type
🔗 Related Issue
🔀 Description of Change
🧪 How to Test
📸 Screenshots / Videos
📝 Additional Information