🐛 fix(builtin-tool-local-system): honor glob scope in local system tool#13875
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## canary #13875 +/- ##
=======================================
Coverage 66.75% 66.75%
=======================================
Files 2043 2043
Lines 174015 174015
Branches 20440 20443 +3
=======================================
Hits 116170 116170
Misses 57721 57721
Partials 124 124
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
canisminor1990
added a commit
that referenced
this pull request
Apr 16, 2026
* 🔨 chore: update .vscode/settings.json (#13894) * 🐛 fix(builtin-tool-local-system): honor glob scope in local system tool (#13875) Made-with: Cursor * 📝 docs: Update changelog docs and release skills (#13897) - Update changelog documentation format across all historical changelog files - Merge release-changelog-style skill into version-release skill - Update changelog examples with improved formatting and structure Made-with: Cursor --------- Co-authored-by: YuTengjing <ytj2713151713@gmail.com> Co-authored-by: Innei <i@innei.in>
Innei
added a commit
that referenced
this pull request
Apr 16, 2026
* 🔖 chore(release): release version v2.1.50 [skip ci] * 📝 docs: Update changelog docs and release skills (#13897) * 🔨 chore: update .vscode/settings.json (#13894) * 🐛 fix(builtin-tool-local-system): honor glob scope in local system tool (#13875) Made-with: Cursor * 📝 docs: Update changelog docs and release skills (#13897) - Update changelog documentation format across all historical changelog files - Merge release-changelog-style skill into version-release skill - Update changelog examples with improved formatting and structure Made-with: Cursor --------- Co-authored-by: YuTengjing <ytj2713151713@gmail.com> Co-authored-by: Innei <i@innei.in> * 🐛 fix: resolve merge conflicts in sync main to canary Restore canary versions of skill docs that were overwritten during main-to-canary sync, keeping #13899 improvements intact. --------- Co-authored-by: CanisMinor <i@canisminor.cc> Co-authored-by: YuTengjing <ytj2713151713@gmail.com> Co-authored-by: Innei <i@innei.in> Co-authored-by: Innei <tukon479@gmail.com>
mrsimpson
added a commit
to mrsimpson/lobehub
that referenced
this pull request
May 8, 2026
* 🔨 chore: update .vscode/settings.json (lobehub#13894) * 🐛 fix(builtin-tool-local-system): honor glob scope in local system tool (lobehub#13875) Made-with: Cursor * 📝 docs: Update changelog docs and release skills (lobehub#13897) - Update changelog documentation format across all historical changelog files - Merge release-changelog-style skill into version-release skill - Update changelog examples with improved formatting and structure Made-with: Cursor --------- Co-authored-by: YuTengjing <ytj2713151713@gmail.com> Co-authored-by: Innei <i@innei.in>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💻 Change Type
🔗 Related Issue
N/A
🔀 Description of Change
The local system
globLocalFilestool previously dropped the user-providedscopewhen delegating to the desktop glob implementation. Relative glob patterns were effectively resolved without a search root, so searches could fall back to the process working directory instead of the intended folder.This change maps IPC
scopethroughComputerRuntimeusing the normalizeddirectoryfield and denormalizes it back toscopeforlocalFileService.globFiles, while keeping the globpatternunchanged. A regression test asserts the service receivespatternandscopetogether.🧪 How to Test
Ran:
bunx vitest run --config vitest.config.mtsinpackages/builtin-tool-local-system.📸 Screenshots / Videos
N/A (non-UI)
📝 Additional Information
None.
Made with Cursor