🐛 fix(desktop): prevent invalid proxy toggle saves#13850
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## canary #13850 +/- ##
==========================================
+ Coverage 66.73% 66.85% +0.11%
==========================================
Files 2043 2043
Lines 173894 173979 +85
Branches 17061 17111 +50
==========================================
+ Hits 116054 116315 +261
+ Misses 57716 57540 -176
Partials 124 124
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Contributor
🚀 Desktop App Build Completed!Version: 📦 Release Download · 📥 Actions Artifacts Build Artifacts
Warning Note: This is a temporary build for testing purposes only. |
…olor variables Signed-off-by: Innei <tukon479@gmail.com>
…null
CI runs with coverage instrumentation cause these form-interaction
tests to take ~4–6s each, exceeding the default 5000ms timeout.
Increase describe timeout to 10000ms and add { delay: null } to
all user.type() calls to keep them stable under coverage.
mrsimpson
pushed a commit
to mrsimpson/lobehub
that referenced
this pull request
May 8, 2026
* 🐛 fix(desktop): prevent invalid proxy toggle saves
* 🩹 fix: close proxy form ci gaps
* ✨ style: enhance SaveBar component with updated styles and improved color variables
Signed-off-by: Innei <tukon479@gmail.com>
* 🩹 fix(test): increase ProxyForm test timeout and add explicit delay: null
CI runs with coverage instrumentation cause these form-interaction
tests to take ~4–6s each, exceeding the default 5000ms timeout.
Increase describe timeout to 10000ms and add { delay: null } to
all user.type() calls to keep them stable under coverage.
* 🩹 fix(test): resolve ProxyForm test type errors with user-event v14
---------
Signed-off-by: Innei <tukon479@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💻 Change Type
🔗 Related Issue
None.
🔀 Description of Change
enableProxywhen the current form state is already complete; otherwise the toggle remains an unsaved changeenableProxyin dirty-state tracking so the Save bar appears when toggle changes cannot be committed immediately🧪 How to Test
open
Desktop Settings -> Proxytoggle
Enable Proxywith empty server and port fieldsconfirm the UI stays in an unsaved state instead of raising an immediate save-failed toast
fill a valid proxy configuration and then save or test again
Tested locally
Added/updated tests
No tests needed
📸 Screenshots / Videos
Save failedfromnetworkProxy.setProxySettings.📝 Additional Information
bunx vitest run --silent='passed-only' 'src/routes/(main)/settings/proxy/features/ProxyForm.test.tsx'could not run in this worktree becausevitest.config.mtscannot resolvevite-tsconfig-pathsandvitest/config.bun run type-checkalso fails at the workspace level because this worktree does not have the required dependency/type installation; the failure is not localized to this PR.