🐛 fix: guard non-string content in context-engine to prevent e.trim errors#13753
Merged
Merged
Conversation
…is not a function` Two unguarded `.trim()` / string-concatenation paths in the context-engine could throw or produce garbage text when a message's `content` is not a plain string (multimodal parts array, null tool turns). Both are reached in normal chat and trigger `e.trim is not a function` in production. - `resolveTopicReferences`: filter out non-string content in the fallback `lookupMessages` path before calling `.trim()`. Without this guard, the outer try/catch swallows the TypeError and drops the whole fallback. - `MessageContent` processor: normalize `message.content` (string or parts array) before concatenating file context, instead of relying on implicit `toString()` coercion which emitted `[object Object]` into the LLM prompt. Adds regression tests for both paths.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## canary #13753 +/- ##
=========================================
Coverage 66.56% 66.56%
=========================================
Files 2022 2022
Lines 171262 171265 +3
Branches 20683 17425 -3258
=========================================
+ Hits 113998 114000 +2
- Misses 57139 57140 +1
Partials 125 125
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Merged
canisminor1990
added a commit
that referenced
this pull request
Apr 16, 2026
# 🚀 LobeHub v2.1.50 (20260416) **Release Date:** April 16, 2026\ **Since v2.1.49:** 107 commits · 101 merged PRs · 13 contributors > This weekly release focuses on improving runtime stability and gateway execution consistency, while making Home/Recents workflows faster to navigate and easier to manage in daily use. --- ## ✨ Highlights - **Server-side Human Approval Flow** — Agent runtime now supports more reliable approve/reject/reject-continue handling in gateway mode, reducing stalled execution paths in long-running tasks. (#13829, #13863, #13873) - **Message Gateway End-to-End Hardening** — Gateway message flow, queue handling, tool callback routing, and stop interruption behavior were strengthened for better execution continuity. (#13761, #13816, #13820, #13815) - **Client Tool Execution in Gateway Mode** — Client-executor tools now run more predictably across gateway and desktop callers, with improved executor dispatch behavior. (#13792, #13790) - **Home / Recents / Sidebar Upgrade** — Sidebar layout, custom sort, recents operations, and profile actions were improved to reduce navigation friction in active sessions. (#13719, #13812, #13723, #13739, #13878, #13734) - **Agent Workspace and Documents Expansion** — Working panel and agent document workflows were expanded and polished for better day-to-day agent operations. (#13766, #13857) - **Provider and Model Compatibility Improvements** — Added GLM-5.1 support and refined model/provider edge-case handling, including schema and error-path fixes. (#13757, #13806, #13736, #13740) --- ## 🏗️ Core Agent & Architecture ### Agent runtime and intervention lifecycle - Added server-side human approval and improved runtime coordination across approve/reject decision paths. (#13829, #13863) - Improved interrupted-task handling and operation lifecycle consistency to reduce half-finished runtime states. (#13714) - Refined error classification and payload propagation so downstream surfaces receive clearer actionable errors. (#13736, #13740) ### Execution model and dispatch behavior - Introduced executor-aware runtime behavior to better separate client/server tool execution semantics. (#13758) - Improved tool/plugin resolution and manifest handling to avoid runtime failures on malformed inputs. (#13856, #13840, #13807) --- ## 📱 Gateway & Platform Integrations - Added message gateway support and strengthened queue/error behavior for more stable cross-channel execution. (#13761, #13816, #13820) - Improved gateway callback pipeline with protocol and API additions for `tool_execute` / `tool_result`. (#13762, #13764, #13765) - Improved bot/channel reliability and DM/slash handling in Discord-related paths. (#13805, #13724) --- ## 🖥️ CLI & User Experience - Improved CLI reliability across message/topic operations and build/minify-related paths. (#13731, #13888) - Added image-to-video options and improved command behavior for generation workflows. (#13788) - Improved desktop runtime behavior for remote fetch and Linux notification urgency handling. (#13789, #13782) --- ## 🔧 Tooling - Extracted gateway stream client into `@lobechat/agent-gateway-client` to centralize protocol usage and reduce duplication. (#13866) - Improved built-in tool coverage and runtime support, including GTD server runtime and missing lobe-kb tools. (#13854, #13876) - Updated skill and frontmatter consistency in workflow tooling. (#13730) --- ## 🔒 Security & Reliability - **Security:** Strengthened API key WS auth behavior and safer serverUrl forwarding in gateway-related auth paths. (#13824) - **Reliability:** Reduced runtime stalls by improving gateway stop/interrupt and approval-state routing behavior. (#13815, #13863, #13873) - **Reliability:** Added defensive guards for malformed tool manifests and non-string content edge cases. (#13856, #13753) --- ## 👥 Contributors **101 merged PRs** from **13 contributors** across **107 commits**. ### Community Contributors - @arvinxx - Runtime, gateway, and execution reliability improvements - @Innei - Navigation, workflow UX, and desktop/CLI refinements - @rdmclin2 - Sidebar, recents, and channel behavior updates - @ONLY-yours - Tooling/runtime fixes and model execution compatibility - @tjx666 - Model support and release/tooling maintenance - @nekomeowww - Memory and search-path stability fixes - @cy948 - CLI indexing and command flow fixes - @octo-patch - Local system runtime edge-case fixes - @djthread - Desktop runtime request reliability improvements - @rivertwilight - Documentation and changelog updates - @sudongyuer - Subscription/mobile support improvements - @Zhouguanyang - Provider/model configuration correctness fixes - @lobehubbot - Translation and maintenance automation support --- **Full Changelog**: v2.1.49...v2.1.50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💻 Change Type
🔗 Related Issue
Follow-up to #13715 (
add typeof guard before .trim() calls in context engine) — that PR coveredBaseProcessor.isEmptyMessage,BaseSystemRoleProvider, andSystemRoleInjector, but two other unguarded paths in the context engine still throwe.trim is not a functionfor chats whose history contains non-stringcontent(multimodal parts array, null tool turns).🔀 Description of Change
Two unguarded
.trim()/ string-concatenation paths in the context-engine still reproducee.trim is not a function(seen in production traces):resolveTopicReferences.ts— the fallbacklookupMessagesbranch callsm.content?.trim()andm.content!.trim(). Historical messages can carry non-string content (multimodal parts array,nullfrom tool-only assistant turns). When that happens, theTypeErroris swallowed by the outertry/catchat the per-topic level and the entire recent-messages fallback silently drops. Guard withtypeof m.content === 'string'before trimming.MessageContent.tsprocessor —let textContent = message.content || ''followed by(textContent + '\n\n' + filesContext).trim(). Whenmessage.contentis already a parts array (an upstream processor normalized it earlier),+coerces viaArray.prototype.toString()and emits[object Object],[object Object]\n\n<!-- SYSTEM CONTEXT ...straight into the LLM prompt. Normalize to a text string first — use the string directly, or extracttype === 'text'parts from the array.🧪 How to Test
Regression tests added:
resolveTopicReferences.test.tsshould skip messages whose content is not a string (array / object)— mixed-content fallback keeps string messages, skips array/object ones.should not throw when every fallback message has non-string content— graceful fallthrough to no-context.MessageContent.test.tsshould not stringify array content when concatenating file context— multimodal user message + file context must not produce[object Object]in the text part.Full
@lobechat/context-enginesuite: 757/757 pass.📝 Additional Information
Both files predate #13715 — the trim fix only patched three known spots. These two are pre-existing latent bugs that the production trace surfaced after non-string content started flowing through both paths.