🐛 fix(task): include config in getTaskDetail response#13521
Merged
Conversation
|
Deployment failed with the following error: View Documentation: https://vercel.com/docs/accounts/team-members-and-roles |
Member
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## canary #13521 +/- ##
===========================================
+ Coverage 66.43% 83.83% +17.39%
===========================================
Files 1977 549 -1428
Lines 163655 35896 -127759
Branches 18716 5894 -12822
===========================================
- Hits 108724 30093 -78631
+ Misses 54809 5681 -49128
Partials 122 122
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
5d9b378 to
f842444
Compare
The task detail API was returning checkpoint and review extracted from config, but not the config object itself. This meant frontend selectors for model/provider (stored in config via task.updateConfig) could never read the values back. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
f842444 to
7e36a81
Compare
Merged
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getTaskDetailwas extractingcheckpointandreviewfrom the task'sconfigJSONB column, but not returning theconfigobject itself. This meant model/provider overrides written viatask.updateConfig(#13502) could never be read back by the frontend.Adds
configto the detail response soTaskDetailData.config.model/TaskDetailData.config.providerselectors work end-to-end.Changes
src/server/services/task/index.ts: Addconfigfield togetTaskDetailreturn valueTest plan
task.updateConfig→ calltask.detail→ verifyconfig.modelandconfig.providerare present in responsecc @arvinxx
🤖 Generated with Claude Code