Skip to content

🔨 chore(task): add generic updateTaskConfig for safe config merging#13502

Merged
arvinxx merged 2 commits into
canaryfrom
feat/lobe-6634-update-task-config
Apr 2, 2026
Merged

🔨 chore(task): add generic updateTaskConfig for safe config merging#13502
arvinxx merged 2 commits into
canaryfrom
feat/lobe-6634-update-task-config

Conversation

@arvinxx

@arvinxx arvinxx commented Apr 2, 2026

Copy link
Copy Markdown
Member

Summary

  • Add updateTaskConfig method to TaskModel for safely merge-updating the task config JSON (read → shallow merge → write)
  • Add task.updateConfig TRPC procedure exposing the new generic method
  • Refactor updateCheckpointConfig / updateReviewConfig to delegate to updateTaskConfig, eliminating duplicated merge logic
  • Update tool execution runtime to use updateTaskConfig instead of manual config merging

Fixes LOBE-6634

Test plan

  • All 54 existing task model tests pass
  • Type check passes
  • Verify updateConfig TRPC endpoint works via client

🤖 Generated with Claude Code

@arvinxx @claude
✨ feat(task): add generic updateTaskConfig method for safe config mer…
7dc9169 
…ging

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@vercel

vercel Bot commented Apr 2, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
lobehub Error Error Apr 2, 2026 10:20am

Request Review

sourcery-ai[bot]
sourcery-ai Bot reviewed Apr 2, 2026
View reviewed changes

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @arvinxx, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@lobehubbot

lobehubbot commented Apr 2, 2026

Copy link
Copy Markdown
Member

Assigning reviewers based on changed files (database model, TRPC router, tool execution service):

@Innei @nekomeowww Could you review this PR? It adds a generic updateTaskConfig method to the TaskModel and exposes it via a new TRPC procedure, refactoring existing checkpoint/review config update logic to eliminate duplicated merge code.

@arvinxx @claude
✅ test: add updateTaskConfig tests and use deep merge
55bb729 
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@arvinxx arvinxx changed the title ✨ feat(task): add generic updateTaskConfig for safe config merging 🔨 chore(task): add generic updateTaskConfig for safe config merging Apr 2, 2026
@codecov

codecov Bot commented Apr 2, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 45.16129% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.47%. Comparing base (04b32e3) to head (55bb729).
⚠️ Report is 2 commits behind head on canary.

Additional details and impacted files 
@@            Coverage Diff            @@
##           canary   #13502     +/-   ##
=========================================
  Coverage   66.47%   66.47%             
=========================================
  Files        1975     1975             
  Lines      162211   162232     +21     
  Branches    15594    19360   +3766     
=========================================
+ Hits       107829   107849     +20     
- Misses      54262    54263      +1     
  Partials      120      120
Flag Coverage Δ
app 58.28% <19.04%> (-0.01%) ⬇️
database 92.56% <100.00%> (+0.04%) ⬆️
packages/agent-runtime 88.98% <ø> (ø)
packages/context-engine 86.51% <ø> (ø)
packages/conversation-flow 92.36% <ø> (ø)
packages/file-loaders 87.02% <ø> (ø)
packages/memory-user-memory 66.68% <ø> (ø)
packages/model-bank 99.85% <ø> (ø)
packages/model-runtime 84.74% <ø> (+0.07%) ⬆️
packages/prompts 66.71% <ø> (ø)
packages/python-interpreter 92.90% <ø> (ø)
packages/ssrf-safe-fetch 0.00% <ø> (ø)
packages/utils 90.41% <ø> (ø)
packages/web-crawler 88.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Store 66.60% <ø> (ø)
Services 49.24% <ø> (ø)
Server 66.34% <19.04%> (-0.03%) ⬇️
Libs 51.03% <ø> (ø)
Utils 91.01% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@arvinxx arvinxx merged commit 074de03 into canary Apr 2, 2026
32 of 34 checks passed
@arvinxx arvinxx deleted the feat/lobe-6634-update-task-config branch April 2, 2026 10:41
@lobehubbot

lobehubbot commented Apr 2, 2026

Copy link
Copy Markdown
Member

❤️ Great PR @arvinxx ❤️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.

@sudongyuer sudongyuer mentioned this pull request Apr 2, 2026
Merged
1 task
@nekomeowww nekomeowww mentioned this pull request Apr 7, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@arvinxx @lobehubbot