Skip to content

πŸ› fix: add the creds tools into execAgentRuntime#13399

Merged
ONLY-yours merged 1 commit intocanaryfrom
fix/credsInBackEnd
Mar 30, 2026
Merged

πŸ› fix: add the creds tools into execAgentRuntime#13399
ONLY-yours merged 1 commit intocanaryfrom
fix/credsInBackEnd

Conversation

@ONLY-yours
Copy link
Copy Markdown
Member

@ONLY-yours ONLY-yours commented Mar 30, 2026

πŸ’» Change Type

  • ✨ feat
  • πŸ› fix
  • ♻️ refactor
  • πŸ’„ style
  • πŸ‘· build
  • ⚑️ perf
  • βœ… test
  • πŸ“ docs
  • πŸ”¨ chore

πŸ”— Related Issue

πŸ”€ Description of Change

πŸ§ͺ How to Test

  • Tested locally
  • Added/updated tests
  • No tests needed

πŸ“Έ Screenshots / Videos

Before After
... ...

πŸ“ Additional Information

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 30, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
lobehub Ready Ready Preview, Comment Mar 30, 2026 6:44am

Request Review

sourcery-ai[bot]
sourcery-ai bot reviewed Mar 30, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine

@lobehubbot
Copy link
Copy Markdown
Member

lobehubbot commented Mar 30, 2026

πŸ‘‹ @arvinxx Could you review this PR? It adds creds tools into execAgentRuntime, touching packages/builtin-tool-creds and src/server/services/toolExecution/serverRuntimes which are in your domain.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 30, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 21.50538% with 73 lines in your changes missing coverage. Please review.
βœ… Project coverage is 66.85%. Comparing base (91b2653) to head (7da4900).
⚠️ Report is 4 commits behind head on canary.

Additional details and impacted files 
@@            Coverage Diff             @@
##           canary   #13399      +/-   ##
==========================================
- Coverage   66.88%   66.85%   -0.03%     
==========================================
  Files        1905     1906       +1     
  Lines      154323   154416      +93     
  Branches    18472    17769     -703     
==========================================
+ Hits       103222   103242      +20     
- Misses      50981    51054      +73     
  Partials      120      120
Flag Coverage Ξ”
app 58.44% <21.50%> (-0.04%) ⬇️
database 96.66% <ΓΈ> (ΓΈ)
packages/agent-runtime 89.26% <ΓΈ> (ΓΈ)
packages/context-engine 86.51% <ΓΈ> (ΓΈ)
packages/conversation-flow 92.36% <ΓΈ> (ΓΈ)
packages/file-loaders 87.02% <ΓΈ> (ΓΈ)
packages/memory-user-memory 66.68% <ΓΈ> (ΓΈ)
packages/model-bank 99.85% <ΓΈ> (ΓΈ)
packages/model-runtime 84.44% <ΓΈ> (ΓΈ)
packages/prompts 67.76% <ΓΈ> (ΓΈ)
packages/python-interpreter 92.90% <ΓΈ> (ΓΈ)
packages/ssrf-safe-fetch 0.00% <ΓΈ> (ΓΈ)
packages/utils 90.41% <ΓΈ> (ΓΈ)
packages/web-crawler 88.82% <ΓΈ> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Ξ”
Store 67.03% <ΓΈ> (ΓΈ)
Services 49.30% <ΓΈ> (ΓΈ)
Server 67.16% <21.50%> (-0.11%) ⬇️
Libs 51.03% <ΓΈ> (ΓΈ)
Utils 91.01% <ΓΈ> (ΓΈ)
πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

chatgpt-codex-connector[bot]
chatgpt-codex-connector bot reviewed Mar 30, 2026
View reviewed changes
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ’‘ Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7da49005f6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with πŸ‘.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

packages/builtin-tool-creds/src/ExecutionRuntime/index.ts
// Get the authorization URL
// Note: In background execution, we cannot use window.location.origin
// The redirect URI should be configured for server-side OAuth flow
const redirectUri = `https://app.lobehub.com/oauth/callback/success?provider=${provider}`;
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Derive OAuth redirect URI from deployment origin

Avoid hardcoding the OAuth callback to https://app.lobehub.com: when initiateOAuthConnect runs on self-hosted, staging, or custom-domain deployments, the returned authorization link redirects to the cloud site instead of the current instance, so the flow cannot reliably return to the user’s active environment and may fail to complete there. Use deployment-aware config (for example APP_URL/request origin) or inject the redirect URI via runtime context.

Useful? React with πŸ‘Β / πŸ‘Ž.

@ONLY-yours ONLY-yours merged commit 9c08fa5 into canary Mar 30, 2026
46 of 51 checks passed
@ONLY-yours ONLY-yours deleted the fix/credsInBackEnd branch March 30, 2026 09:20
@lobehubbot
Copy link
Copy Markdown
Member

lobehubbot commented Mar 30, 2026

❀️ Great PR @ONLY-yours ❀️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.

cy948 pushed a commit to cy948/lobe-chat that referenced this pull request Mar 31, 2026
@ONLY-yours @cy948
πŸ› fix: add the creds tools into execAgentRuntime (lobehub#13399)
cdd2137 
fix: add the creds tools into execAgentRuntime
@nekomeowww nekomeowww mentioned this pull request Apr 7, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ONLY-yours @lobehubbot