Skip to content

✅ test: add unit tests for LocalTaskScheduler#13398

Merged
arvinxx merged 1 commit intocanaryfrom
automatic/add-tests-taskScheduler-2026-03-30
Mar 30, 2026
Merged

✅ test: add unit tests for LocalTaskScheduler#13398
arvinxx merged 1 commit intocanaryfrom
automatic/add-tests-taskScheduler-2026-03-30

Conversation

@lobehubbot
Copy link
Copy Markdown
Member

@lobehubbot lobehubbot commented Mar 30, 2026

Summary

  • Added unit tests for LocalTaskScheduler in src/server/services/taskScheduler/impls/
  • Total test files added: 1
  • Test cases added: 12
  • Coverage focus: Scheduling logic, cancellation, callback execution, error handling, and concurrency

Changes

  • All tests pass successfully
  • Business logic coverage improved
  • Edge cases and error handling covered
  • Tests follow existing patterns

Module Processed

src/server/services/taskScheduler/impls/local.ts

Test Coverage

  • Functions tested: scheduleNextTopic, cancelScheduled, setExecutionCallback
  • Coverage type: unit
  • Test approach: Uses vi.useFakeTimers() to control setTimeout behavior; tests happy paths, zero/missing delay, callback errors, multiple concurrent schedules, cancellation, and no-op cancel on unknown IDs

🤖 Generated with Claude Code

@github-actions @claude
✅ test: add unit tests for LocalTaskScheduler
5cb2c55 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel bot commented Mar 30, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
lobehub Ready Ready Preview, Comment Mar 30, 2026 6:16am

Request Review

sourcery-ai[bot]
sourcery-ai bot reviewed Mar 30, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine

@lobehubbot
Copy link
Copy Markdown
Member Author

lobehubbot commented Mar 30, 2026

@nekomeowww - This is a backend service test PR for LocalTaskScheduler. Please take a look.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 30, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.89%. Comparing base (91b2653) to head (5cb2c55).
⚠️ Report is 6 commits behind head on canary.

Additional details and impacted files 
@@           Coverage Diff            @@
##           canary   #13398    +/-   ##
========================================
  Coverage   66.88%   66.89%            
========================================
  Files        1905     1906     +1     
  Lines      154323   154360    +37     
  Branches    18472    17781   -691     
========================================
+ Hits       103222   103259    +37     
  Misses      50981    50981            
  Partials      120      120
Flag Coverage Δ
app 58.49% <ø> (+0.01%) ⬆️
database 96.66% <ø> (ø)
packages/agent-runtime 89.26% <ø> (ø)
packages/context-engine 86.51% <ø> (ø)
packages/conversation-flow 92.36% <ø> (ø)
packages/file-loaders 87.02% <ø> (ø)
packages/memory-user-memory 66.68% <ø> (ø)
packages/model-bank 99.85% <ø> (ø)
packages/model-runtime 84.44% <ø> (ø)
packages/prompts 67.76% <ø> (ø)
packages/python-interpreter 92.90% <ø> (ø)
packages/ssrf-safe-fetch 0.00% <ø> (ø)
packages/utils 90.41% <ø> (ø)
packages/web-crawler 88.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Store 67.03% <ø> (ø)
Services 49.30% <ø> (ø)
Server 67.30% <ø> (+0.03%) ⬆️
Libs 51.03% <ø> (ø)
Utils 91.01% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@arvinxx arvinxx merged commit 2f5a31f into canary Mar 30, 2026
22 of 23 checks passed
@arvinxx arvinxx deleted the automatic/add-tests-taskScheduler-2026-03-30 branch March 30, 2026 10:53
@lobehubbot
Copy link
Copy Markdown
Member Author

lobehubbot commented Mar 30, 2026

❤️ Great PR @lobehubbot ❤️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.

cy948 pushed a commit to cy948/lobe-chat that referenced this pull request Mar 31, 2026
@lobehubbot @github-actions
@claude @cy948
✅ test: add unit tests for LocalTaskScheduler (lobehub#13398)
39911f8 
Co-authored-by: claude[bot] <41898282+claude[bot]@users.noreply.github.com>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lobehubbot @arvinxx