♻️ refactor: remove DefaultAgentForm UI from settings pages#13342
Merged
♻️ refactor: remove DefaultAgentForm UI from settings pages#13342
Conversation
Remove the user-facing Default Agent configuration form from both the agent settings page and the service-model settings page. The underlying store action and selectors are preserved for programmatic use (e.g. onboarding). Fixes LOBE-1125 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
|
@ONLY-yours - This is a settings refactor (removing DefaultAgentForm from settings pages). Please take a look. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## canary #13342 +/- ##
==========================================
+ Coverage 66.84% 66.85% +0.01%
==========================================
Files 1891 1890 -1
Lines 151669 151613 -56
Branches 14572 15275 +703
==========================================
- Hits 101376 101363 -13
+ Misses 50173 50130 -43
Partials 120 120
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Member
|
❤️ Great PR @arvinxx ❤️ The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world. |
cy948
pushed a commit
to cy948/lobe-chat
that referenced
this pull request
Mar 31, 2026
…13342) 🔥 refactor: remove DefaultAgentForm UI from settings pages Remove the user-facing Default Agent configuration form from both the agent settings page and the service-model settings page. The underlying store action and selectors are preserved for programmatic use (e.g. onboarding). Fixes LOBE-1125 Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💻 Change Type
🔗 Related Issue
Fixes LOBE-1125
🔀 Description of Change
Remove the user-facing Default Agent configuration form from both the agent settings page and the service-model settings page. The underlying store action (
updateDefaultAgent) and selectors are preserved for programmatic use (e.g. onboarding flow).Changes:
DefaultAgentForm.tsxcomponent<DefaultAgentForm />fromsettings/agent/index.tsx<DefaultAgentForm />fromsettings/service-model/index.tsx🧪 How to Test
updateDefaultAgentprogrammatically)